From 1dccc0bc81e36d56324bdc8ef434d8feb668740f Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Wed, 16 Jun 2021 14:04:30 +0000 Subject: [PATCH] [FIX] base: avoid crash due to generation of key with model Until now, when you create a view of type qweb with a model, we use the model as first part to generate the key. Since this model can contains dot, it is wrong and we got some key like ir.ui.view.gen_key_xyz This bug has been seen with commit ee8756b31186f2f21e9b70e124f29c678cebaea7 which make the installation of website & sale_timesheet impossible in dev mode. File /home/odoo/addons/base/models/ir_ui_view.py, line 294, in _compute_arch arch_fs = get_view_arch_from_file(fullpath, xml_id) File /home/odoo/addons/base/models/ir_ui_view.py, line 166, in get_view_arch_from_file module, view_id = xmlid.split('.') Too many values to unpack Now we never try to make key beautiful. At first view it doesn't bring any advantage, but only bug. closes odoo/odoo#72238 Signed-off-by: Romain Derie --- odoo/addons/base/models/ir_ui_view.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/odoo/addons/base/models/ir_ui_view.py b/odoo/addons/base/models/ir_ui_view.py index 0f5fca8cc53..9dea181dc69 100644 --- a/odoo/addons/base/models/ir_ui_view.py +++ b/odoo/addons/base/models/ir_ui_view.py @@ -499,8 +499,6 @@ actual arch. pass if not values.get('key') and values.get('type') == 'qweb': values['key'] = "gen_key.%s" % str(uuid.uuid4())[:6] - if values.get('model'): - values['key'] = "%s.gen_key_%s" % (values.get('model'), str(uuid.uuid4())[:6]) if not values.get('name'): values['name'] = "%s %s" % (values.get('model'), values['type']) # Create might be called with either `arch` (xml files), `arch_base` (form view) or `arch_db`.