From 1d9ffe45be89fa4edc75b391740bafb75647631a Mon Sep 17 00:00:00 2001
From: Simon Lejeune <sle@openerp.com>
Date: Thu, 18 Jul 2019 09:52:53 +0000
Subject: [PATCH] [REF] stock: hide show reserved option on form view

This way we keep the current behavior of the barcode client action but
we don't display move lines on receipt.

Users could edit the view, display "show_reserved" and check it to get
back the old behavior in the form views.

task-2028780

Co-authored-by: svs-odoo <svs@odoo.com>
---
 addons/mrp/views/stock_picking_views.xml   | 3 ---
 addons/stock/models/stock_picking.py       | 4 +++-
 addons/stock/views/stock_picking_views.xml | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/addons/mrp/views/stock_picking_views.xml b/addons/mrp/views/stock_picking_views.xml
index f211caf3105..7f2f8612502 100644
--- a/addons/mrp/views/stock_picking_views.xml
+++ b/addons/mrp/views/stock_picking_views.xml
@@ -109,9 +109,6 @@
                     <field name="use_create_components_lots"/>
                 </group>
             </xpath>
-            <field name="show_reserved" position="attributes">
-                <attribute name="attrs">{"invisible": [("code", "=", "mrp_operation")]}</attribute>
-            </field>
         </field>
     </record>
 </odoo>
diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py
index 41ede9c0c26..6fb3e38f3cb 100644
--- a/addons/stock/models/stock_picking.py
+++ b/addons/stock/models/stock_picking.py
@@ -52,7 +52,9 @@ class PickingType(models.Model):
         'Show Detailed Operations', default=_default_show_operations,
         help="If this checkbox is ticked, the pickings lines will represent detailed stock operations. If not, the picking lines will represent an aggregate of detailed stock operations.")
     show_reserved = fields.Boolean(
-        'Show Reserved', default=True, help="If this checkbox is ticked, Odoo will show which products are reserved (lot/serial number, source location, source package).")
+        'Pre-fill Detailed Operations', default=True,
+        help="If this checkbox is ticked, Odoo will automatically pre-fill the detailed "
+        "operations with the corresponding products, locations and lot/serial numbers.")
 
     # Statistics for the kanban view
     count_picking_draft = fields.Integer(compute='_compute_picking_count')
diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index 5e426fcf455..94817885b15 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -48,7 +48,7 @@
                                 <field name="code"/>
                                 <field attrs='{"invisible": [("code", "not in", ["incoming", "outgoing", "internal"])]}' name="return_picking_type_id"/>
                                 <field name="show_operations"/>
-                                <field name="show_reserved" attrs="{'invisible': [('show_operations', '!=', False)]}"/>
+                                <field name="show_reserved" attrs="{'invisible': [('code', '!=', 'incoming')]}"/>
                             </group>
                         </group>
                         <group>