From 05ca984c3efb5ddd5ac27297e65f248bd7a2b3a1 Mon Sep 17 00:00:00 2001
From: "Purnendu Singh (OpenERP)" <psi@tinyerp.com>
Date: Wed, 28 Mar 2012 12:56:55 +0530
Subject: [PATCH 1/3] [IMP] stock: improve the logic of fields_view_get metthod

bzr revid: psi@tinyerp.com-20120328072655-2k4c27dh0u5wsaod
---
 addons/stock/stock.py | 66 ++++++++++++++++---------------------------
 1 file changed, 25 insertions(+), 41 deletions(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index 8473c31a103..a25e2503ba0 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -710,26 +710,18 @@ class stock_picking(osv.osv):
             for field in res['fields']:
                 # To update the states label according to shipping type
                 if field == 'state':
-                    _state = []
-                    for key, value in PICK_STATE:
-                        if type == 'in':
-                            if key == 'assigned':
-                                value = _('Ready to Receive')
-                            elif key == 'done':
-                                value = _('Received')
-                        elif type == 'internal':
-                            if key == 'assigned':
-                                value = _('Ready to Transfer')
-                            elif key == 'done':
-                                value = _('Transferred')
-                        elif type == 'out':
-                            if key == 'assigned':
-                                value = _('Ready to Deliver')
-                            elif key == 'done':
-                                value = _('Delivered')
-                        _state.append((key,value))
-                    res['fields']['state']['selection'] = _state
-                    res['fields']['state']['help'] = self._tooltip_picking_state(dict(_state))
+                    _state = dict(PICK_STATE)
+                    if type == 'in':
+                        _state['assigned'] = _('Ready to Receive')
+                        _state['done'] = _('Received')
+                    elif type == 'internal':
+                        _state['assigned'] = _('Ready to Transfer')
+                        _state['done'] = _('Transferred')
+                    elif type == 'out':
+                        _state['assigned'] = _('Ready to Deliver')
+                        _state['done'] = _('Delivered')
+                    res['fields']['state']['selection'] = [(x[0], _state[x[0]]) for x in PICK_STATE]
+                    res['fields']['state']['help'] = self._tooltip_picking_state(_state)
                 # To update the fields tooltips according to shipping type
                 if field == 'address_id':
                     _tooltip = ''
@@ -1736,28 +1728,20 @@ class stock_move(osv.osv):
                 for node in doc.xpath("//group/button[@string='Process Now']"):
                     node.set('string', _('Deliver'))
             for field in res['fields']:
-#                # To update the states label according to the containing shipping type
+                # To update the states label according to shipping type
                 if field == 'state':
-                    _state = []
-                    for key, value in MOVE_STATE:
-                        if type == 'in':
-                            if key == 'assigned':
-                                value = _('Ready to Receive')
-                            elif key == 'done':
-                                value = _('Received')
-                        elif type == 'internal':
-                            if key == 'assigned':
-                                value = _('Ready to Transfer')
-                            elif key == 'done':
-                                value = _('Transferred')
-                        elif type == 'out':
-                            if key == 'assigned':
-                                value = _('Ready to Deliver')
-                            elif key == 'done':
-                                value = _('Delivered')
-                        _state.append((key,value))
-                    res['fields']['state']['selection'] = _state
-                    res['fields']['state']['help'] = self._tooltip_move_state(dict(_state))
+                    _state = dict(MOVE_STATE)
+                    if type == 'in':
+                        _state['assigned'] = _('Ready to Receive')
+                        _state['done'] = _('Received')
+                    elif type == 'internal':
+                        _state['assigned'] = _('Ready to Transfer')
+                        _state['done'] = _('Transferred')
+                    elif type == 'out':
+                        _state['assigned'] = _('Ready to Deliver')
+                        _state['done'] = _('Delivered')
+                    res['fields']['state']['selection'] = [(x[0], _state[x[0]]) for x in MOVE_STATE]
+                    res['fields']['state']['help'] = self._tooltip_move_state(_state)
                     res['arch'] = etree.tostring(doc)
         return res
 

From 7b4d697213f76f7da3644ff49157a5bc3b5c88ac Mon Sep 17 00:00:00 2001
From: "Purnendu Singh (OpenERP)" <psi@tinyerp.com>
Date: Wed, 28 Mar 2012 16:28:31 +0530
Subject: [PATCH 2/3] [IMP] stock: in case of reception hide the waiting
 avaibility state and flow goes to direct from draft to ready to receive

bzr revid: psi@tinyerp.com-20120328105831-4dbllz7rm0klpvdj
---
 addons/stock/stock.py       | 2 ++
 addons/stock/stock_view.xml | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/addons/stock/stock.py b/addons/stock/stock.py
index a25e2503ba0..065a83263c8 100644
--- a/addons/stock/stock.py
+++ b/addons/stock/stock.py
@@ -890,6 +890,8 @@ class stock_picking(osv.osv):
         #TOFIX: assignment of move lines should be call before testing assigment otherwise picking never gone in assign state
         ok = True
         for pick in self.browse(cr, uid, ids):
+            if pick.type == 'in':
+                return True
             mt = pick.move_type
             for move in pick.move_lines:
                 if (move.state in ('confirmed', 'draft')) and (mt == 'one'):
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 2a137aa6235..be095e2dd04 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -1211,7 +1211,7 @@
                                 </form>
                             </field>
                             <group col="10" colspan="4">
-                                <field name="state" readonly="1" widget="statusbar" statusbar_visible="draft,confirmed,assigned,done" statusbar_colors='{"auto":"blue", "confirmed":"blue"}'/>
+                                <field name="state" readonly="1" widget="statusbar" statusbar_visible="draft,assigned,done" statusbar_colors='{"auto":"blue", "confirmed":"blue"}'/>
                                 <button name="draft_force_assign" states="draft" string="Confirm" type="object" icon="gtk-ok"/>
                                 <button name="draft_validate" states="draft" string="Confirm &amp; Receive" type="object" icon="gtk-media-play"/>
                                 <button name="action_assign" states="confirmed" string="Check Availability" type="object" icon="gtk-find"/>

From aacaef33ec101b5ba5a689c1735ef88cd4e354b2 Mon Sep 17 00:00:00 2001
From: "Purnendu Singh (OpenERP)" <psi@tinyerp.com>
Date: Wed, 28 Mar 2012 17:01:07 +0530
Subject: [PATCH 3/3] [IMP] stock: improve the wizard

bzr revid: psi@tinyerp.com-20120328113107-bcgfgzldp8ii0rtl
---
 addons/stock/wizard/stock_partial_picking.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/stock/wizard/stock_partial_picking.py b/addons/stock/wizard/stock_partial_picking.py
index 8a256258c52..d3e50968d90 100644
--- a/addons/stock/wizard/stock_partial_picking.py
+++ b/addons/stock/wizard/stock_partial_picking.py
@@ -138,7 +138,7 @@ class stock_partial_picking(osv.osv_memory):
     def _partial_move_for(self, cr, uid, move):
         partial_move = {
             'product_id' : move.product_id.id,
-            'quantity' : move.state in ('assigned','new') and move.product_qty or 0,
+            'quantity' : move.state in ('assigned','draft','confirmed') and move.product_qty or 0,
             'product_uom' : move.product_uom.id,
             'prodlot_id' : move.prodlot_id.id,
             'move_id' : move.id,