From 1c993ea34ef19fbdd1ba4aa46fbba1b85c9b2d0d Mon Sep 17 00:00:00 2001
From: "Xavier Bol (xbo)" <xbo@odoo.com>
Date: Mon, 16 Oct 2023 11:54:22 +0200
Subject: [PATCH] [FIX] hr,hr_holidays: show icon even if employee has no user
 linked

Before this commit, in the form view of employee, the presence status
icon displayed in the top right of the avatar image is hidden if there
is no last activity or no user linked to the employee.

This commit changes the visibility condition to have the same
visibility condition defined in the kanban view for the same icon.

task-3556262

Part-of: odoo/odoo#138803
---
 addons/hr/views/hr_employee_views.xml | 3 ++-
 addons/hr_holidays/views/hr_views.xml | 3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/addons/hr/views/hr_employee_views.xml b/addons/hr/views/hr_employee_views.xml
index e2dca6d8019..7a61d658452 100644
--- a/addons/hr/views/hr_employee_views.xml
+++ b/addons/hr/views/hr_employee_views.xml
@@ -79,7 +79,8 @@
                             </div>
                             <div class="o_employee_avatar m-0 p-0">
                                 <field name="image_1920" widget='image' class="oe_avatar m-0" options='{"zoom": true, "preview_image":"avatar_128"}'/>
-                                <field name="hr_icon_display" class="d-flex align-items-end fs-6 o_employee_availability" widget="hr_presence_status"/>
+                                <field name="show_hr_icon_display" invisible="1" />
+                                <field name="hr_icon_display" class="d-flex align-items-end fs-6 o_employee_availability" invisible="not show_hr_icon_display or not id" widget="hr_presence_status"/>
                             </div>
                         </div>
                         <group>
diff --git a/addons/hr_holidays/views/hr_views.xml b/addons/hr_holidays/views/hr_views.xml
index 3d1801bc204..edec6517d0f 100644
--- a/addons/hr_holidays/views/hr_views.xml
+++ b/addons/hr_holidays/views/hr_views.xml
@@ -119,9 +119,6 @@
         <field name="inherit_id" ref="hr.view_employee_form"/>
         <field name = "priority" eval="20" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='hr_icon_display']" position="attributes">
-                <attribute name="invisible">not last_activity or not id</attribute>
-            </xpath>
             <xpath expr="//group[@name='managers']" position="inside">
                 <field name="leave_manager_id" widget="many2one_avatar_user"/>
             </xpath>