From 1c542adf863f6de731fda24a9ddc712337bceb61 Mon Sep 17 00:00:00 2001 From: William Henrotin Date: Wed, 19 Jun 2019 09:53:52 +0000 Subject: [PATCH] [FIX] stock: calling 'get()' on None This commit tests that values is not falsy before accessing a key closes odoo/odoo#34343 Signed-off-by: Simon Lejeune (sle) --- addons/stock/models/stock_warehouse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/stock/models/stock_warehouse.py b/addons/stock/models/stock_warehouse.py index aad9f297179..343a8840200 100644 --- a/addons/stock/models/stock_warehouse.py +++ b/addons/stock/models/stock_warehouse.py @@ -679,7 +679,7 @@ class Warehouse(models.Model): route_rule_values.update(values or {}) rules_list.append(route_rule_values) first_rule = False - if values.get('propagate_cancel') and rules_list: + if values and values.get('propagate_cancel') and rules_list: # In case of rules chain with cancel propagation set, we need to stop # the cancellation for the last step in order to avoid cancelling # any other move after the chain.