From 1b7f55a15e3b98ff26e45ccfb1999f3e97d6f680 Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Tue, 19 May 2020 12:37:06 +0000 Subject: [PATCH] [IMP] website_forum: perf - replace any by in Usinf of any seems not efficient in this case > timeit.timeit('any(7 == o for o in [1,3,5,7,9,12])', number=10000000) 6.556934245978482 > timeit.timeit('7 in set([1,3,5,7,9,12])', number=10000000) 2.78867393406108 > timeit.timeit('7 in [1,3,5,7,9,12]', number=10000000) 0.534781630965881 --- addons/website_forum/models/forum.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_forum/models/forum.py b/addons/website_forum/models/forum.py index 98cd889e12d..200a5b54c03 100644 --- a/addons/website_forum/models/forum.py +++ b/addons/website_forum/models/forum.py @@ -401,7 +401,7 @@ class Post(models.Model): def _get_uid_has_answered(self): for post in self: - post.uid_has_answered = any(answer.create_uid.id == post._uid for answer in post.child_ids) + post.uid_has_answered = post._uid in post.child_ids.create_uid.ids @api.depends('child_ids.is_correct') def _get_has_validated_answer(self):