From fb1ef15a5a66e3fa6d42294442e2492ef434426b Mon Sep 17 00:00:00 2001 From: "Julien (juc) Castiaux" Date: Tue, 4 Dec 2018 15:54:17 +0000 Subject: [PATCH 1/8] [FIX] l10n_be: Account 451200 must be reconciliable opw-1913108 closes odoo/odoo#29251 --- addons/l10n_be/data/account_pcmn_belgium_data.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/addons/l10n_be/data/account_pcmn_belgium_data.xml b/addons/l10n_be/data/account_pcmn_belgium_data.xml index b8730176185..268e18de317 100644 --- a/addons/l10n_be/data/account_pcmn_belgium_data.xml +++ b/addons/l10n_be/data/account_pcmn_belgium_data.xml @@ -558,6 +558,7 @@ Compte courant administration T.V.A. 4512 + From 3b39c31adc5f39e5148f4db97428b2913e07c54c Mon Sep 17 00:00:00 2001 From: "Julien (juc) Castiaux" Date: Wed, 5 Dec 2018 09:29:19 +0000 Subject: [PATCH 2/8] [FIX] website_forum_doc: Not possible to change ToC order opw-1913300 closes odoo/odoo#29263 --- addons/website_forum_doc/models/forum_documentation_toc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_forum_doc/models/forum_documentation_toc.py b/addons/website_forum_doc/models/forum_documentation_toc.py index fc167f1ed80..bb6a04aa670 100644 --- a/addons/website_forum_doc/models/forum_documentation_toc.py +++ b/addons/website_forum_doc/models/forum_documentation_toc.py @@ -8,7 +8,7 @@ class Documentation(models.Model): _name = 'forum.documentation.toc' _description = 'Documentation ToC' _inherit = ['website.seo.metadata'] - _order = "parent_left" + _order = "sequence, name" _parent_order = "sequence, name" _parent_store = True From d1604542262d73c5d76477a4593e13b78557b480 Mon Sep 17 00:00:00 2001 From: Nicolas Martinelli Date: Wed, 5 Dec 2018 13:47:56 +0000 Subject: [PATCH 3/8] [FIX] base_vat: Albania The module `vatnumber` (which is not maintained anymore) uses an incorrect validation method for Albanian VAT numbers. Therefore, we use the library `stdnum`, on which `vatnumber` relies for most cases. opw-1912680 closes odoo/odoo#29280 --- addons/base_vat/models/res_partner.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/addons/base_vat/models/res_partner.py b/addons/base_vat/models/res_partner.py index 69eb983cc62..38624b35142 100644 --- a/addons/base_vat/models/res_partner.py +++ b/addons/base_vat/models/res_partner.py @@ -361,3 +361,10 @@ class ResPartner(models.Model): return int(vat[9]) == c1 and int(vat[10]) == c2 return False + + def check_vat_al(self, vat): + try: + import stdnum.al + return stdnum.al.vat.is_valid(vat) + except ImportError: + return True From 81c26383b0ce7a977d990e818bedb56c81abf3be Mon Sep 17 00:00:00 2001 From: Jairo Llopis Date: Tue, 4 Dec 2018 12:13:39 +0000 Subject: [PATCH 4/8] [FIX] auth_ldap: Avoid sending email for newly created user If installed along with `auth_signup`, it sends an email when creating a missing user authenticated through LDAP. It is a confusing message that makes no sense, because the user is, from his POV, not actually creating a new user, but just authenticating with a new app with his known company-wide credentials. Besides, that invitation leads the user to change his password in Odoo, although he probably doesn't want to do that and have a password for Odoo and another in the LDAP server. The best option is to disable that email completely, which is what this commit does. closes odoo/odoo#29243 --- addons/auth_ldap/models/res_company_ldap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/auth_ldap/models/res_company_ldap.py b/addons/auth_ldap/models/res_company_ldap.py index 05dcb275afa..effea64a67b 100644 --- a/addons/auth_ldap/models/res_company_ldap.py +++ b/addons/auth_ldap/models/res_company_ldap.py @@ -193,7 +193,7 @@ class CompanyLDAP(models.Model): elif conf['create_user']: _logger.debug("Creating new Odoo user \"%s\" from LDAP" % login) values = self.map_ldap_attributes(conf, login, ldap_entry) - SudoUser = self.env['res.users'].sudo() + SudoUser = self.env['res.users'].sudo().with_context(no_reset_password=True) if conf['user']: values['active'] = True user_id = SudoUser.browse(conf['user'][0]).copy(default=values).id From 379fc6b125b08ce2ce6473d01887100e1f8e0ed0 Mon Sep 17 00:00:00 2001 From: Laurent Smet Date: Wed, 5 Dec 2018 11:13:19 +0100 Subject: [PATCH 5/8] [FIX] account_accountant: Make transfer_account not required without chart template required: [('chart_template_id','!=',False)] doesn't work because you need to fill the chart_template_id to install a chart of accounts for your company. Then, the transfer_account becomes required before its installation and then, you are not able to install a chart of accounts for your company. --- addons/account_accountant/views/res_config_view.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/account_accountant/views/res_config_view.xml b/addons/account_accountant/views/res_config_view.xml index 1375e72501e..945acf8146c 100644 --- a/addons/account_accountant/views/res_config_view.xml +++ b/addons/account_accountant/views/res_config_view.xml @@ -71,7 +71,7 @@
From 23d9aeb22d2c17929ba7c016f0ef2f629ce0a718 Mon Sep 17 00:00:00 2001 From: "Julien (juc) Castiaux" Date: Fri, 7 Dec 2018 15:21:38 +0000 Subject: [PATCH 6/8] [FIX] website_project: buggy pager The pager wasn't taking care of the filter opw-1912293 closes odoo/odoo#29360 --- addons/website_project/controllers/main.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/website_project/controllers/main.py b/addons/website_project/controllers/main.py index d5f86b3db51..cf355828462 100644 --- a/addons/website_project/controllers/main.py +++ b/addons/website_project/controllers/main.py @@ -99,15 +99,16 @@ class WebsiteAccount(website_account): domain += [('create_date', '>', date_begin), ('create_date', '<=', date_end)] # pager + count = request.env['project.task'].search_count(domain) pager = request.website.pager( url="/my/tasks", url_args={'date_begin': date_begin, 'date_end': date_end, 'sortby': sortby, 'project': project}, - total=values['task_count'], + total=count, page=page, step=self._items_per_page ) # content according to pager and archive selected - tasks = request.env['project.task'].search(domain, order=order, limit=self._items_per_page, offset=pager['offset']) + tasks = request.env['project.task'].search(domain, order=order, limit=self._items_per_page, offset=(page - 1) * self._items_per_page) values.update({ 'date': date_begin, From 54238c88e85d6eb2bce20bae15f77713140af636 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Fri, 7 Dec 2018 12:28:43 +0000 Subject: [PATCH 7/8] [FIX] mail: wrong many2many definition The definition of `attachment_ids` on model `email_template.preview` is wrong, because its table/columns refer to the model `mail.template`. As the field is only used to preview a result in a wizard form, it does not need to be stored. closes odoo/odoo#29349 --- addons/mail/wizard/email_template_preview.py | 1 + odoo/fields.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/addons/mail/wizard/email_template_preview.py b/addons/mail/wizard/email_template_preview.py index 678dbfa3ee5..a05badd0359 100644 --- a/addons/mail/wizard/email_template_preview.py +++ b/addons/mail/wizard/email_template_preview.py @@ -34,6 +34,7 @@ class TemplatePreview(models.TransientModel): res_id = fields.Selection(_get_records, 'Sample Document') partner_ids = fields.Many2many('res.partner', string='Recipients') + attachment_ids = fields.Many2many(string='Attachments', store=False) @api.onchange('res_id') @api.multi diff --git a/odoo/fields.py b/odoo/fields.py index b472e35658b..c1e11fef022 100644 --- a/odoo/fields.py +++ b/odoo/fields.py @@ -2329,6 +2329,8 @@ class Many2many(_RelationalMulti): self.column2 = '%s_id' % comodel._table # check validity of table name check_pg_name(self.relation) + else: + self.relation = self.column1 = self.column2 = None def _setup_regular_full(self, model): super(Many2many, self)._setup_regular_full(model) From f69c004795e0a7f32d5c6243cc3d4915cf010bbe Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Tue, 11 Dec 2018 10:23:50 +0000 Subject: [PATCH 8/8] [FIX] website_membership: correctly check if customize view is active Commit 5804246e0fca introduced some improvements to speed up performances. One of them was to check if a customize_show view was active or not but the condition was on view.customize_show instead of view.active. Thus, as that view is always a customize_show, the condition would always be met. closes odoo/odoo#29414 --- addons/website_membership/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website_membership/controllers/main.py b/addons/website_membership/controllers/main.py index 1784f30b949..2b37b49d016 100644 --- a/addons/website_membership/controllers/main.py +++ b/addons/website_membership/controllers/main.py @@ -103,7 +103,7 @@ class WebsiteMembership(http.Controller): # get google maps localization of partners google_map_partner_ids = [] - if request.env.ref('website_membership.opt_index_google_map').customize_show: + if request.env.ref('website_membership.opt_index_google_map').active: google_map_partner_ids = MembershipLine.search(line_domain).get_published_companies(limit=2000) search_domain = [('membership_state', '=', 'free'), ('website_published', '=', True)]