From 1ac1ad0fefbaa5cfd60a4ffec63bc573a8ebde1d Mon Sep 17 00:00:00 2001
From: Louis Baudoux <lba@odoo.com>
Date: Fri, 16 Sep 2022 13:17:20 +0000
Subject: [PATCH] [FIX] web: AutoComplete render only if options are available

There was a small graphical bug caused by the `<ul>` element being
rendered even when no options were available.

X-original-commit: 32d87b2097e550b375bdc2098cdee6c669666a3a
Part-of: odoo/odoo#102220
---
 addons/web/static/src/core/autocomplete/autocomplete.js  | 9 +++++++++
 addons/web/static/src/core/autocomplete/autocomplete.xml | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/src/core/autocomplete/autocomplete.js b/addons/web/static/src/core/autocomplete/autocomplete.js
index 897c439ba7b..5e68ce478f4 100644
--- a/addons/web/static/src/core/autocomplete/autocomplete.js
+++ b/addons/web/static/src/core/autocomplete/autocomplete.js
@@ -49,6 +49,15 @@ export class AutoComplete extends Component {
         return this.state.open;
     }
 
+    get hasOptions() {
+        for (const source of this.sources) {
+            if (source.isLoading || source.options.length) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     open(useInput = false) {
         this.state.open = true;
         this.loadSources(useInput);
diff --git a/addons/web/static/src/core/autocomplete/autocomplete.xml b/addons/web/static/src/core/autocomplete/autocomplete.xml
index cc5051c0c1e..a0e79b48677 100644
--- a/addons/web/static/src/core/autocomplete/autocomplete.xml
+++ b/addons/web/static/src/core/autocomplete/autocomplete.xml
@@ -17,7 +17,7 @@
                 t-on-keydown="onInputKeydown"
                 t-ref="input"
             />
-            <t t-if="isOpened">
+            <t t-if="isOpened and hasOptions">
                 <ul class="o-autocomplete--dropdown-menu dropdown-menu ui-widget ui-autocomplete show" t-on-mousedown.prevent="" t-ref="sourcesList">
                     <t t-foreach="sources" t-as="source" t-key="source.id">
                         <t t-if="source.isLoading">