From 197bb9c3941990a0df597b1367222744a7a00a6a Mon Sep 17 00:00:00 2001
From: jbw-odoo <jbw@odoo.com>
Date: Mon, 22 Jan 2024 13:34:20 +0100
Subject: [PATCH] [FIX] purchase*: remove readonly param on account fields

Product template "property_account_expense_id" and "property_account_creditor_price_difference" fields must stay editable in cases even if not "can be puchased".
Since it being readonly is trivial, better leave it writeable instead of implementing cross module readonly logic.

closes odoo/odoo#150601

Task: 3695677
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
---
 addons/purchase/views/product_views.xml       | 3 ---
 addons/purchase_stock/views/product_views.xml | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/addons/purchase/views/product_views.xml b/addons/purchase/views/product_views.xml
index 3f23a37f8fe..b383f9cb98d 100644
--- a/addons/purchase/views/product_views.xml
+++ b/addons/purchase/views/product_views.xml
@@ -88,9 +88,6 @@
             <field name="model">product.template</field>
             <field name="inherit_id" ref="account.product_template_form_view"/>
             <field name="arch" type="xml">
-                <field name="property_account_expense_id" position="attributes">
-                    <attribute name="readonly">purchase_ok == 0</attribute>
-                </field>
                 <field name='supplier_taxes_id' position="replace" >
                      <field name="supplier_taxes_id" colspan="2" widget="many2many_tags" readonly="purchase_ok == 0" context="{'default_type_tax_use':'purchase'}"/>
                 </field>
diff --git a/addons/purchase_stock/views/product_views.xml b/addons/purchase_stock/views/product_views.xml
index c5f84a09926..7c764f53e74 100644
--- a/addons/purchase_stock/views/product_views.xml
+++ b/addons/purchase_stock/views/product_views.xml
@@ -19,7 +19,7 @@
         <field name="inherit_id" ref="account.product_template_form_view"/>
         <field name="arch" type="xml">
             <field name="property_account_expense_id" position="after">
-                <field name="property_account_creditor_price_difference" domain="[('deprecated','=',False)]" readonly="purchase_ok == 0" groups="account.group_account_readonly"/>
+                <field name="property_account_creditor_price_difference" domain="[('deprecated','=',False)]" groups="account.group_account_readonly"/>
             </field>
         </field>
     </record>