From 17ec1676f3d3e88fdb90f37e099ff4302c436b5d Mon Sep 17 00:00:00 2001
From: Kevin Baptiste <kba@odoo.com>
Date: Wed, 1 Mar 2023 10:36:55 +0000
Subject: [PATCH] [FIX] hr_skills: add proper padding

A double line would appear if the resume / skills were empty.

task-3196398

closes odoo/odoo#114144

X-original-commit: 35ffc195e807db3fd5ea1576816c631d219863c0
Signed-off-by: Kevin Baptiste <kba@odoo.com>
---
 addons/hr_skills/static/src/fields/resume_one2many.xml | 2 +-
 addons/hr_skills/static/src/fields/skills_one2many.xml | 2 +-
 addons/hr_skills/views/hr_views.xml                    | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/hr_skills/static/src/fields/resume_one2many.xml b/addons/hr_skills/static/src/fields/resume_one2many.xml
index 95d2cdbc23b..bef3347f8bd 100644
--- a/addons/hr_skills/static/src/fields/resume_one2many.xml
+++ b/addons/hr_skills/static/src/fields/resume_one2many.xml
@@ -2,7 +2,7 @@
 <odoo>
     <t t-name="hr_skills.ResumeListRenderer" owl="1" t-inherit-mode="primary" t-inherit="hr_skills.SkillsListRenderer">
         <xpath expr="//table" position="attributes">
-            <attribute name="t-attf-class" add="table-borderless" remove="table-striped" separator=" "/>
+            <attribute name="t-attf-class" add="table-borderless {{ !showTable ? 'd-none' : ''}}" remove="table-striped" separator=" "/>
         </xpath>
         <xpath expr="//thead/tr" position="replace">
             <tr>
diff --git a/addons/hr_skills/static/src/fields/skills_one2many.xml b/addons/hr_skills/static/src/fields/skills_one2many.xml
index fa770f69c6b..9d87b555abb 100644
--- a/addons/hr_skills/static/src/fields/skills_one2many.xml
+++ b/addons/hr_skills/static/src/fields/skills_one2many.xml
@@ -2,7 +2,7 @@
 <odoo>
     <t t-name="hr_skills.SkillsListRenderer" owl="1" t-inherit-mode="primary" t-inherit="web.ListRenderer">
         <xpath expr="//table" position="attributes">
-            <attribute name="t-attf-class" add="mb-1 {{ !isEditable ? 'cursor-default' : '' }} o_skill_table" separator=" "/>
+            <attribute name="t-attf-class" add="mb-1 {{ !isEditable ? 'cursor-default' : '' }} {{ !showTable ? 'd-none' : ''}} o_skill_table" separator=" "/>
         </xpath>
         <xpath expr="//thead" position="attributes">
             <attribute name="style">visibility: collapse;</attribute>
diff --git a/addons/hr_skills/views/hr_views.xml b/addons/hr_skills/views/hr_views.xml
index 31a5c91f3b9..ffdfcd6cb25 100644
--- a/addons/hr_skills/views/hr_views.xml
+++ b/addons/hr_skills/views/hr_views.xml
@@ -66,7 +66,7 @@
                 <page name="public" string="Resume">
                     <div class="row">
                         <div class="o_hr_skills_editable o_hr_skills_group o_group_resume col-lg-7 d-flex flex-column">
-                            <separator string="Resume"/>
+                            <separator string="Resume" class="mb-4"/>
                             <!-- This field uses a custom tree view rendered by the 'resume_one2many' widget.
                                 Adding fields in the tree arch below makes them accessible to the widget
                             -->
@@ -83,7 +83,7 @@
 
                         </div>
                         <div class="o_hr_skills_editable o_hr_skills_group o_group_skills col-lg-5 d-flex flex-column">
-                            <separator string="Skills"/>
+                            <separator string="Skills" class="mb-4"/>
                             <field mode="tree" nolabel="1" name="employee_skill_ids" widget="skills_one2many">
                                 <tree>
                                     <field name="skill_type_id" invisible="1"/>