From 17a25ee69d75bfd28b8c25fb82e32c8bb9f8f611 Mon Sep 17 00:00:00 2001 From: Toufik Ben Jaa Date: Tue, 20 Dec 2022 09:11:29 +0000 Subject: [PATCH] [FIX] web: incorrect CSS selector - When clicking on settings we get a crash for an incorrect CSS selector. `Caused by: SyntaxError: Element.querySelectorAll: 'footer:not(field footer' is not a valid selector` This issue happens on outdated version of Firefox (tested on firefox 78) closes odoo/odoo#108371 X-original-commit: 68b05bc9911f899a2b8a8c3335af90d9ed8129cb Signed-off-by: Aaron Bohy (aab) --- addons/web/static/src/views/form/form_controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/views/form/form_controller.js b/addons/web/static/src/views/form/form_controller.js index 1d57981c92f..41a1d43b75a 100644 --- a/addons/web/static/src/views/form/form_controller.js +++ b/addons/web/static/src/views/form/form_controller.js @@ -167,7 +167,7 @@ export class FormController extends Component { // select footers that are not in subviews and move them to another arch // that will be moved to the dialog's footer (if we are in a dialog) - const footers = [...this.archInfo.xmlDoc.querySelectorAll("footer:not(field footer")]; + const footers = [...this.archInfo.xmlDoc.querySelectorAll("footer:not(field footer)")]; if (footers.length) { this.footerArchInfo = Object.assign({}, this.archInfo); this.footerArchInfo.xmlDoc = createElement("t");