From 16de0f70a07ded8c006f94bf53b5ed68ee7cb2fe Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Fri, 26 Apr 2024 10:41:46 +0200 Subject: [PATCH] [FIX] web: restore proper public widgets onFailure in old guardedCatch Commit [1] made a mistake when adapting the guardedCatch handler. [1]: https://github.com/odoo/odoo/commit/fcb16a3b1bd373726ffb54f0fbe41fb6d1784769 closes odoo/odoo#163486 Signed-off-by: Quentin Smetz (qsm) --- addons/web/static/src/legacy/js/public/public_root.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/legacy/js/public/public_root.js b/addons/web/static/src/legacy/js/public/public_root.js index 86793f50a8c..73635d0427f 100644 --- a/addons/web/static/src/legacy/js/public/public_root.js +++ b/addons/web/static/src/legacy/js/public/public_root.js @@ -246,7 +246,9 @@ export const PublicRoot = publicWidget.RootWidget.extend({ this._startWidgets(ev.data.$target, ev.data.options) .then(ev.data.onSuccess) .catch((e) => { - ev.data.onFailure(e); + if (ev.data.onFailure) { + ev.data.onFailure(e); + } if (!(e instanceof RPCError)) { return Promise.reject(e); }