From 16cd396d03d0d27b165d9baff46991f26ba5bddb Mon Sep 17 00:00:00 2001 From: "Andrea Grazioso (agr-odoo)" Date: Tue, 7 Jan 2020 09:32:43 +0000 Subject: [PATCH] [FIX] hr_holidays: fix traceback on timeoff form Remove "Time Off" permission from a normal user (i.e. Marc Demo) Login in as the user, go to Time Off > Managers (Time Off) > Create Switch user. Traceback will popup. This is caused by the computed field function acquiring empty fields on change so the date_from will be False opw-2166477 closes odoo/odoo#42859 X-original-commit: 57a6e8be9eb6ff31cb1edb7878f8c5dc913df8ec Signed-off-by: Nicolas Martinelli (nim) --- addons/hr_holidays/models/hr_leave.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index 18db4c33d19..789c7aa85f1 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -930,7 +930,7 @@ class HolidaysRequest(models.Model): if state == 'draft': if holiday.state == 'refuse': raise UserError(_('Only a Time Off Manager can reset a refused leave.')) - if holiday.date_from.date() <= fields.Date.today(): + if holiday.date_from and holiday.date_from.date() <= fields.Date.today(): raise UserError(_('Only a Time Off Manager can reset a started leave.')) if holiday.employee_id != current_employee: raise UserError(_('Only a Time Off Manager can reset other people leaves.'))