From 1480f2fad5be82dc1bfa5293cece7a58f877b5e7 Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Wed, 12 Apr 2023 11:29:10 +0000 Subject: [PATCH] [FIX] *: `session.modified` has been renamed `is_dirty` Since odoo/odoo@04e972660b3f38c8dfa42111b1fe88adbcff4699 The session `modified` flag has been renamed `is_dirty`. However, it has not been renamed correctly in these three different places. The goal to set `modified` at this three places is to force the session to be saved, for instance because a mutable (a list or a dict) contained in the session was modified, but not the dict of the session itself, therefore `modified` is not flagged automatically. As the flag `modified` has not been renamed to `is_dirty`, a key/value `modified: True` was actually assigned to the session dict, and saved in file. The behavior to save the session in these three places was kept, as one key/value of the session has been changed, but by the way to assign a new value in the session file, which is not ideal. It's better to assign the correct flag to avoid setting a new key/value in the session for no reason. closes odoo/odoo#118719 X-original-commit: b6f4a27f2d95d5bc5510f4da50132ab66d8c86aa Signed-off-by: Julien Castiaux (juc) Signed-off-by: Denis Ledoux (dle) --- addons/hr_attendance/controllers/main.py | 2 +- addons/website_blog/controllers/main.py | 2 +- addons/website_sale_wishlist/controllers/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/hr_attendance/controllers/main.py b/addons/hr_attendance/controllers/main.py index 66534933c60..aacd4049b37 100644 --- a/addons/hr_attendance/controllers/main.py +++ b/addons/hr_attendance/controllers/main.py @@ -8,5 +8,5 @@ from odoo.http import request class HrAttendance(http.Controller): @http.route('/hr_attendance/kiosk_keepalive', auth='user', type='json') def kiosk_keepalive(self): - request.httprequest.session.modified = True + request.session.touch() return {} diff --git a/addons/website_blog/controllers/main.py b/addons/website_blog/controllers/main.py index 46e9aec2875..63ad44c45f8 100644 --- a/addons/website_blog/controllers/main.py +++ b/addons/website_blog/controllers/main.py @@ -306,5 +306,5 @@ class WebsiteBlog(http.Controller): if not request.session.get('posts_viewed'): request.session['posts_viewed'] = [] request.session['posts_viewed'].append(blog_post.id) - request.session.modified = True + request.session.touch() return response diff --git a/addons/website_sale_wishlist/controllers/main.py b/addons/website_sale_wishlist/controllers/main.py index eabf8510608..5a10016148e 100644 --- a/addons/website_sale_wishlist/controllers/main.py +++ b/addons/website_sale_wishlist/controllers/main.py @@ -54,7 +54,7 @@ class WebsiteSaleWishlist(WebsiteSale): wish_ids = request.session.get('wishlist_ids') or [] if wish.id in wish_ids: request.session['wishlist_ids'].remove(wish.id) - request.session.modified = True + request.session.touch() wish.sudo().unlink() else: wish.unlink()