From 14807da76e4b8987fc5d08d62243cd43d594da4c Mon Sep 17 00:00:00 2001
From: Kevin Baptiste <kba@odoo.com>
Date: Wed, 15 Apr 2020 10:09:04 +0000
Subject: [PATCH] [IMP] project: hide 'View Task' in email

Hide the View Task button in the emails sent to a task's followers based
on the project's privacy settings.

closes odoo/odoo#49021

Taskid: 2230189
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/project/models/project.py | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/addons/project/models/project.py b/addons/project/models/project.py
index 4da8ee5c2d0..5ae41e236c7 100644
--- a/addons/project/models/project.py
+++ b/addons/project/models/project.py
@@ -894,11 +894,12 @@ class Task(models.Model):
         self.ensure_one()
 
         project_user_group_id = self.env.ref('project.group_project_user').id
-        new_group = (
-            'group_project_user',
-            lambda pdata: pdata['type'] == 'user' and project_user_group_id in pdata['groups'],
-            {},
-        )
+
+        group_func = lambda pdata: pdata['type'] == 'user' and project_user_group_id in pdata['groups']
+        if self.project_id.privacy_visibility == 'followers':
+            allowed_user_ids = self.project_id.allowed_internal_user_ids.partner_id.ids
+            group_func = lambda pdata: pdata['type'] == 'user' and project_user_group_id in pdata['groups'] and pdata['id'] in allowed_user_ids
+        new_group = ('group_project_user', group_func, {})
 
         if not self.user_id and not self.stage_id.fold:
             take_action = self._notify_get_action_link('assign')
@@ -907,9 +908,17 @@ class Task(models.Model):
 
         groups = [new_group] + groups
 
+        if self.project_id.privacy_visibility == 'portal':
+            allowed_user_ids = self.project_id.allowed_portal_user_ids.partner_id.ids
+            groups.insert(0, (
+                'allowed_portal_users',
+                lambda pdata: pdata['type'] == 'portal' and pdata['id'] in allowed_user_ids,
+                {}
+            ))
+
         for group_name, group_method, group_data in groups:
-            if group_name != 'customer':
-                group_data['has_button_access'] = True
+            if group_name in ('customer', 'portal_customer', 'user'):
+                group_data['has_button_access'] = False
 
         return groups