From a80f32bbe5e829c0a1b39c336cc9b3c711b17d64 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Fri, 17 Mar 2023 10:53:38 +0000 Subject: [PATCH 1/4] [FIX] delivery: translate warning title Part-of: odoo/odoo#115811 --- addons/delivery/wizard/choose_delivery_carrier.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/delivery/wizard/choose_delivery_carrier.py b/addons/delivery/wizard/choose_delivery_carrier.py index f535d54eefa..595244999cb 100644 --- a/addons/delivery/wizard/choose_delivery_carrier.py +++ b/addons/delivery/wizard/choose_delivery_carrier.py @@ -47,8 +47,8 @@ class ChooseDeliveryCarrier(models.TransientModel): vals = self._get_shipment_rate() if vals.get('error_message'): warning = { - 'title': '%s Error' % self.carrier_id.name, - 'message': vals.get('error_message'), + 'title': _("%(carrier)s Error", carrier=self.carrier_id.name), + 'message': vals['error_message'], 'type': 'notification', } return {'warning': warning} From f203b1e730989a7f2526dbbe1a21ca2480948dc9 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Fri, 17 Mar 2023 10:59:14 +0000 Subject: [PATCH 2/4] [CLN] delivery: clean files organization Part-of: odoo/odoo#115811 --- addons/delivery/__manifest__.py | 15 +++--- addons/delivery/data/delivery_data.xml | 48 +++++++++---------- addons/delivery/data/delivery_demo.xml | 5 +- .../report/ir_actions_report_templates.xml | 16 ++++--- .../security/delivery_carrier_security.xml | 10 ---- addons/delivery/security/ir_rules.xml | 10 ++++ addons/delivery/views/partner_view.xml | 15 ------ addons/delivery/views/res_partner_views.xml | 15 ++++++ .../res_config_settings_views.xml | 10 ++-- 9 files changed, 76 insertions(+), 68 deletions(-) delete mode 100644 addons/delivery/security/delivery_carrier_security.xml create mode 100644 addons/delivery/security/ir_rules.xml delete mode 100644 addons/delivery/views/partner_view.xml create mode 100644 addons/delivery/views/res_partner_views.xml rename addons/delivery/{views => wizard}/res_config_settings_views.xml (68%) diff --git a/addons/delivery/__manifest__.py b/addons/delivery/__manifest__.py index 7ee5795749e..2db49895707 100644 --- a/addons/delivery/__manifest__.py +++ b/addons/delivery/__manifest__.py @@ -13,14 +13,17 @@ The system is able to add and compute the shipping line. """, 'depends': ['sale'], 'data': [ - 'security/ir.model.access.csv', - 'security/delivery_carrier_security.xml', - 'views/delivery_view.xml', - 'views/partner_view.xml', 'data/delivery_data.xml', - 'views/res_config_settings_views.xml', - 'wizard/choose_delivery_carrier_views.xml', + 'security/ir.model.access.csv', + 'security/ir_rules.xml', + 'report/ir_actions_report_templates.xml', + + 'views/delivery_view.xml', + 'views/res_partner_views.xml', + + 'wizard/res_config_settings_views.xml', + 'wizard/choose_delivery_carrier_views.xml', ], 'demo': ['data/delivery_demo.xml'], 'installable': True, diff --git a/addons/delivery/data/delivery_data.xml b/addons/delivery/data/delivery_data.xml index 593f26a8064..60218e39dda 100644 --- a/addons/delivery/data/delivery_data.xml +++ b/addons/delivery/data/delivery_data.xml @@ -1,26 +1,26 @@ - - - - - Deliveries - - - Standard delivery - Delivery_007 - service - - - - 0.0 - order - - - Standard delivery - 0.0 - 1 - fixed - - - + + + + + Deliveries + + + Standard delivery + Delivery_007 + service + + + + 0.0 + order + + + Standard delivery + 0.0 + 1 + fixed + + + diff --git a/addons/delivery/data/delivery_demo.xml b/addons/delivery/data/delivery_demo.xml index 61a742f2405..58cd283fe1f 100644 --- a/addons/delivery/data/delivery_demo.xml +++ b/addons/delivery/data/delivery_demo.xml @@ -1,6 +1,5 @@ - - + @@ -71,5 +70,5 @@ - + diff --git a/addons/delivery/report/ir_actions_report_templates.xml b/addons/delivery/report/ir_actions_report_templates.xml index af24fc3e9cb..ef9c7f4fb0f 100644 --- a/addons/delivery/report/ir_actions_report_templates.xml +++ b/addons/delivery/report/ir_actions_report_templates.xml @@ -1,11 +1,13 @@ - + diff --git a/addons/delivery/security/delivery_carrier_security.xml b/addons/delivery/security/delivery_carrier_security.xml deleted file mode 100644 index 32566b4ced5..00000000000 --- a/addons/delivery/security/delivery_carrier_security.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - - - Delivery Carrier multi-company - - ['|', ('company_id', 'in', company_ids), ('company_id', '=', False)] - - - diff --git a/addons/delivery/security/ir_rules.xml b/addons/delivery/security/ir_rules.xml new file mode 100644 index 00000000000..748f1e96d34 --- /dev/null +++ b/addons/delivery/security/ir_rules.xml @@ -0,0 +1,10 @@ + + + + + Delivery Carrier multi-company + + ['|', ('company_id', 'in', company_ids), ('company_id', '=', False)] + + + diff --git a/addons/delivery/views/partner_view.xml b/addons/delivery/views/partner_view.xml deleted file mode 100644 index fddac9ad72d..00000000000 --- a/addons/delivery/views/partner_view.xml +++ /dev/null @@ -1,15 +0,0 @@ - - - - - res.partner.carrier.property.form.inherit - res.partner - - - - - - - - - diff --git a/addons/delivery/views/res_partner_views.xml b/addons/delivery/views/res_partner_views.xml new file mode 100644 index 00000000000..66c42b53ed1 --- /dev/null +++ b/addons/delivery/views/res_partner_views.xml @@ -0,0 +1,15 @@ + + + + + res.partner.carrier.property.form.inherit + res.partner + + + + + + + + + diff --git a/addons/delivery/views/res_config_settings_views.xml b/addons/delivery/wizard/res_config_settings_views.xml similarity index 68% rename from addons/delivery/views/res_config_settings_views.xml rename to addons/delivery/wizard/res_config_settings_views.xml index 665e9907a0a..af650dd599b 100644 --- a/addons/delivery/views/res_config_settings_views.xml +++ b/addons/delivery/wizard/res_config_settings_views.xml @@ -6,13 +6,17 @@ res.config.settings - +
-
-
+
From e9b6dae8e6db88a46b86af398d16362e5c437440 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Fri, 17 Mar 2023 11:00:41 +0000 Subject: [PATCH 3/4] [CLN] delivery: split delivery_view.xml (1) Part-of: odoo/odoo#115811 --- ...ry_view.xml => delivery_carrier_views.xml} | 0 .../views/delivery_price_rule_views.xml | 300 ++++++++++++++++++ .../views/delivery_zip_prefix_views.xml | 300 ++++++++++++++++++ addons/delivery/views/sale_order_views.xml | 300 ++++++++++++++++++ 4 files changed, 900 insertions(+) rename addons/delivery/views/{delivery_view.xml => delivery_carrier_views.xml} (100%) create mode 100644 addons/delivery/views/delivery_price_rule_views.xml create mode 100644 addons/delivery/views/delivery_zip_prefix_views.xml create mode 100644 addons/delivery/views/sale_order_views.xml diff --git a/addons/delivery/views/delivery_view.xml b/addons/delivery/views/delivery_carrier_views.xml similarity index 100% rename from addons/delivery/views/delivery_view.xml rename to addons/delivery/views/delivery_carrier_views.xml diff --git a/addons/delivery/views/delivery_price_rule_views.xml b/addons/delivery/views/delivery_price_rule_views.xml new file mode 100644 index 00000000000..17b3e42a077 --- /dev/null +++ b/addons/delivery/views/delivery_price_rule_views.xml @@ -0,0 +1,300 @@ + + + + + delivery.carrier.tree + delivery.carrier + + + + + + + + + + + + + delivery.carrier.search + delivery.carrier + + + + + + + + + + + + + + + delivery.carrier.form + delivery.carrier + +
+ +
+ + + + + +
+ +
+
+ + + + + + + + + + + + + + + + + + + + + + +

+ Filling this form allows you to filter delivery carriers according to the delivery address of your customer. +

+ + + + + +

+ Please select a country before choosing a state or a zip prefix. +

+
+
+ + + +
+
+
+
+
+ + + Shipping Methods + delivery.carrier + tree,form + {'search_default_group_by_provider': True} + +

+ Define a new delivery method +

+ Each carrier (e.g. UPS) can have several delivery methods (e.g. + UPS Express, UPS Standard) with a set of pricing rules attached + to each method. +

+ These methods allow to automatically compute the delivery price + according to your settings; on the sales order (based on the + quotation) or the invoice (based on the delivery orders). +

+
+
+ + + Zip Prefix + delivery.zip.prefix + tree,form + +

+ Manage delivery zip prefixes +

+ Delivery zip prefixes are assigned to delivery carriers to restrict + which zips it is available to. +

+
+
+ + + + + delivery.price.rule.form + delivery.price.rule + +
+ + + + + +
+
+
+ + delivery.price.rule.tree + delivery.price.rule + + + + + + + + + + delivery.sale.order.form.view.with_carrier + sale.order + + + + + + + + + +
+
+
+ + + + + + + + + + recompute_delivery_price and is_delivery + + +
+
+
+ +
diff --git a/addons/delivery/views/delivery_zip_prefix_views.xml b/addons/delivery/views/delivery_zip_prefix_views.xml new file mode 100644 index 00000000000..17b3e42a077 --- /dev/null +++ b/addons/delivery/views/delivery_zip_prefix_views.xml @@ -0,0 +1,300 @@ + + + + + delivery.carrier.tree + delivery.carrier + + + + + + + + + + + + + delivery.carrier.search + delivery.carrier + + + + + + + + + + + + + + + delivery.carrier.form + delivery.carrier + +
+ +
+ + + + + +
+ +
+
+ + + + + + + + + + + + + + + + + + + + + + +

+ Filling this form allows you to filter delivery carriers according to the delivery address of your customer. +

+ + + + + +

+ Please select a country before choosing a state or a zip prefix. +

+
+
+ + + +
+
+
+
+
+ + + Shipping Methods + delivery.carrier + tree,form + {'search_default_group_by_provider': True} + +

+ Define a new delivery method +

+ Each carrier (e.g. UPS) can have several delivery methods (e.g. + UPS Express, UPS Standard) with a set of pricing rules attached + to each method. +

+ These methods allow to automatically compute the delivery price + according to your settings; on the sales order (based on the + quotation) or the invoice (based on the delivery orders). +

+
+
+ + + Zip Prefix + delivery.zip.prefix + tree,form + +

+ Manage delivery zip prefixes +

+ Delivery zip prefixes are assigned to delivery carriers to restrict + which zips it is available to. +

+
+
+ + + + + delivery.price.rule.form + delivery.price.rule + +
+ + + + + +
+
+
+ + delivery.price.rule.tree + delivery.price.rule + + + + + + + + + + delivery.sale.order.form.view.with_carrier + sale.order + + + + + + + + + +
+
+
+ + + + + + + + + + recompute_delivery_price and is_delivery + + +
+
+
+ +
diff --git a/addons/delivery/views/sale_order_views.xml b/addons/delivery/views/sale_order_views.xml new file mode 100644 index 00000000000..17b3e42a077 --- /dev/null +++ b/addons/delivery/views/sale_order_views.xml @@ -0,0 +1,300 @@ + + + + + delivery.carrier.tree + delivery.carrier + + + + + + + + + + + + + delivery.carrier.search + delivery.carrier + + + + + + + + + + + + + + + delivery.carrier.form + delivery.carrier + +
+ +
+ + + + + +
+ +
+
+ + + + + + + + + + + + + + + + + + + + + + +

+ Filling this form allows you to filter delivery carriers according to the delivery address of your customer. +

+ + + + + +

+ Please select a country before choosing a state or a zip prefix. +

+
+
+ + + +
+
+
+
+
+ + + Shipping Methods + delivery.carrier + tree,form + {'search_default_group_by_provider': True} + +

+ Define a new delivery method +

+ Each carrier (e.g. UPS) can have several delivery methods (e.g. + UPS Express, UPS Standard) with a set of pricing rules attached + to each method. +

+ These methods allow to automatically compute the delivery price + according to your settings; on the sales order (based on the + quotation) or the invoice (based on the delivery orders). +

+
+
+ + + Zip Prefix + delivery.zip.prefix + tree,form + +

+ Manage delivery zip prefixes +

+ Delivery zip prefixes are assigned to delivery carriers to restrict + which zips it is available to. +

+
+
+ + + + + delivery.price.rule.form + delivery.price.rule + +
+ + + + + +
+
+
+ + delivery.price.rule.tree + delivery.price.rule + + + + + + + + + + delivery.sale.order.form.view.with_carrier + sale.order + + + + + + + + + +
+
+
+ + + + + + + + + + recompute_delivery_price and is_delivery + + +
+
+
+ +
From 6023c023808792c7804747aa5914728b10c79d4d Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Fri, 17 Mar 2023 11:07:43 +0000 Subject: [PATCH 4/4] [CLN] delivery: split delivery_view.xml (2) Part-of: odoo/odoo#115811 --- addons/delivery/__manifest__.py | 5 +- .../delivery/views/delivery_carrier_views.xml | 478 +++++++----------- .../views/delivery_price_rule_views.xml | 332 ++---------- .../views/delivery_zip_prefix_views.xml | 308 +---------- addons/delivery/views/sale_order_views.xml | 344 ++----------- 5 files changed, 292 insertions(+), 1175 deletions(-) diff --git a/addons/delivery/__manifest__.py b/addons/delivery/__manifest__.py index 2db49895707..1ce793e804a 100644 --- a/addons/delivery/__manifest__.py +++ b/addons/delivery/__manifest__.py @@ -19,8 +19,11 @@ The system is able to add and compute the shipping line. 'report/ir_actions_report_templates.xml', - 'views/delivery_view.xml', + 'views/delivery_carrier_views.xml', + 'views/delivery_price_rule_views.xml', + 'views/delivery_zip_prefix_views.xml', 'views/res_partner_views.xml', + 'views/sale_order_views.xml', 'wizard/res_config_settings_views.xml', 'wizard/choose_delivery_carrier_views.xml', diff --git a/addons/delivery/views/delivery_carrier_views.xml b/addons/delivery/views/delivery_carrier_views.xml index 17b3e42a077..0444223f6b9 100644 --- a/addons/delivery/views/delivery_carrier_views.xml +++ b/addons/delivery/views/delivery_carrier_views.xml @@ -1,300 +1,196 @@ - - - delivery.carrier.tree - delivery.carrier - - - - - - - - - - - - delivery.carrier.search - delivery.carrier - - - - - - - - - - - - + + delivery.carrier.tree + delivery.carrier + + + + + + + + + + - - delivery.carrier.form - delivery.carrier - -
- -
- - - - - -
- -
-
- - - - - - - - - - - - - + + delivery.carrier.search + delivery.carrier + + + + + + + + + + + + + + + delivery.carrier.form + delivery.carrier + + + +
+ + + + + +
+ +
+
+ + + + + + + + + + + + + - - - - - - - - -

- Filling this form allows you to filter delivery carriers according to the delivery address of your customer. -

- - - - - -

- Please select a country before choosing a state or a zip prefix. -

-
-
- - - -
-
- -
-
- - - Shipping Methods - delivery.carrier - tree,form - {'search_default_group_by_provider': True} - -

- Define a new delivery method -

- Each carrier (e.g. UPS) can have several delivery methods (e.g. - UPS Express, UPS Standard) with a set of pricing rules attached - to each method. -

- These methods allow to automatically compute the delivery price - according to your settings; on the sales order (based on the - quotation) or the invoice (based on the delivery orders). -

-
-
- - - Zip Prefix - delivery.zip.prefix - tree,form - -

- Manage delivery zip prefixes -

- Delivery zip prefixes are assigned to delivery carriers to restrict - which zips it is available to. -

-
-
- - - - - delivery.price.rule.form - delivery.price.rule - -
- - - - -
-
-
- - delivery.price.rule.tree - delivery.price.rule - - - - - - - + + + + + + + + +

+ Filling this form allows you to filter delivery carriers according to the delivery address of your customer. +

+ + + + + +

+ Please select a country before choosing a state or a zip prefix. +

+
+
+ + + +
+
+ +
+
- - delivery.sale.order.form.view.with_carrier - sale.order - - - - - - - - - -
-
-
- - - - - - - - - - recompute_delivery_price and is_delivery - - -
-
-
+ + Shipping Methods + delivery.carrier + tree,form + {'search_default_group_by_provider': True} + +

+ Define a new delivery method +

+ Each carrier (e.g. UPS) can have several delivery methods (e.g. + UPS Express, UPS Standard) with a set of pricing rules attached + to each method. +

+ These methods allow to automatically compute the delivery price + according to your settings; on the sales order (based on the + quotation) or the invoice (based on the delivery orders). +

+
+
+ +
diff --git a/addons/delivery/views/delivery_price_rule_views.xml b/addons/delivery/views/delivery_price_rule_views.xml index 17b3e42a077..c45c618fd0d 100644 --- a/addons/delivery/views/delivery_price_rule_views.xml +++ b/addons/delivery/views/delivery_price_rule_views.xml @@ -1,300 +1,44 @@ - - - delivery.carrier.tree - delivery.carrier - - - - - - - - - - - - delivery.carrier.search - delivery.carrier - - - - - - - - - - - - + + delivery.price.rule.form + delivery.price.rule + +
+ + + + + +
+
+
+ + delivery.price.rule.tree + delivery.price.rule + + + + + + + - - delivery.carrier.form - delivery.carrier - -
- -
- - - - - -
- -
-
- - - - - - - - - - - - - - - - - - - - - - -

- Filling this form allows you to filter delivery carriers according to the delivery address of your customer. -

- - - - - -

- Please select a country before choosing a state or a zip prefix. -

-
-
- - - -
-
-
-
-
- - - Shipping Methods - delivery.carrier - tree,form - {'search_default_group_by_provider': True} - -

- Define a new delivery method -

- Each carrier (e.g. UPS) can have several delivery methods (e.g. - UPS Express, UPS Standard) with a set of pricing rules attached - to each method. -

- These methods allow to automatically compute the delivery price - according to your settings; on the sales order (based on the - quotation) or the invoice (based on the delivery orders). -

-
-
- - - Zip Prefix - delivery.zip.prefix - tree,form - -

- Manage delivery zip prefixes -

- Delivery zip prefixes are assigned to delivery carriers to restrict - which zips it is available to. -

-
-
- - - - - delivery.price.rule.form - delivery.price.rule - -
- - - - - -
-
-
- - delivery.price.rule.tree - delivery.price.rule - - - - - - - - - - delivery.sale.order.form.view.with_carrier - sale.order - - - - - - - - - -
-
-
- - - - - - - - - - recompute_delivery_price and is_delivery - - -
-
-
diff --git a/addons/delivery/views/delivery_zip_prefix_views.xml b/addons/delivery/views/delivery_zip_prefix_views.xml index 17b3e42a077..8a84145360b 100644 --- a/addons/delivery/views/delivery_zip_prefix_views.xml +++ b/addons/delivery/views/delivery_zip_prefix_views.xml @@ -1,300 +1,18 @@ - - - delivery.carrier.tree - delivery.carrier - - - - - - - - - - - - delivery.carrier.search - delivery.carrier - - - - - - - - - - - - - - - delivery.carrier.form - delivery.carrier - -
- -
- - - - - -
- -
-
- - - - - - - - - - - - - - - - - - - - - - -

- Filling this form allows you to filter delivery carriers according to the delivery address of your customer. -

- - - - - -

- Please select a country before choosing a state or a zip prefix. -

-
-
- - - -
-
-
-
-
- - - Shipping Methods - delivery.carrier - tree,form - {'search_default_group_by_provider': True} - -

- Define a new delivery method -

- Each carrier (e.g. UPS) can have several delivery methods (e.g. - UPS Express, UPS Standard) with a set of pricing rules attached - to each method. -

- These methods allow to automatically compute the delivery price - according to your settings; on the sales order (based on the - quotation) or the invoice (based on the delivery orders). -

-
-
- - - Zip Prefix - delivery.zip.prefix - tree,form - -

- Manage delivery zip prefixes -

- Delivery zip prefixes are assigned to delivery carriers to restrict - which zips it is available to. -

-
-
- - - - - delivery.price.rule.form - delivery.price.rule - -
- - - - - -
-
-
- - delivery.price.rule.tree - delivery.price.rule - - - - - - - - - - delivery.sale.order.form.view.with_carrier - sale.order - - - - - - - - - -
-
-
- - - - - - - - - - recompute_delivery_price and is_delivery - - -
-
-
+ + Zip Prefix + delivery.zip.prefix + tree,form + +

+ Manage delivery zip prefixes +

+ Delivery zip prefixes are assigned to delivery carriers to restrict + which zips it is available to. +

+
+
diff --git a/addons/delivery/views/sale_order_views.xml b/addons/delivery/views/sale_order_views.xml index 17b3e42a077..f370e1aae2f 100644 --- a/addons/delivery/views/sale_order_views.xml +++ b/addons/delivery/views/sale_order_views.xml @@ -1,300 +1,56 @@ - - - delivery.carrier.tree - delivery.carrier - - - - - - - - - - - - delivery.carrier.search - delivery.carrier - - - - - - - - - - + + delivery.sale.order.form.view.with_carrier + sale.order + + + + + + - - - - delivery.carrier.form - delivery.carrier - -
- -
- - - - - -
- -
-
- - - - - - - - - - - - - - - - - - - - - - -

- Filling this form allows you to filter delivery carriers according to the delivery address of your customer. -

- - - - - -

- Please select a country before choosing a state or a zip prefix. -

-
-
- - - -
-
-
-
-
- - - Shipping Methods - delivery.carrier - tree,form - {'search_default_group_by_provider': True} - -

- Define a new delivery method -

- Each carrier (e.g. UPS) can have several delivery methods (e.g. - UPS Express, UPS Standard) with a set of pricing rules attached - to each method. -

- These methods allow to automatically compute the delivery price - according to your settings; on the sales order (based on the - quotation) or the invoice (based on the delivery orders). -

-
-
- - - Zip Prefix - delivery.zip.prefix - tree,form - -

- Manage delivery zip prefixes -

- Delivery zip prefixes are assigned to delivery carriers to restrict - which zips it is available to. -

-
-
- - - - - delivery.price.rule.form - delivery.price.rule - -
- - - - - -
-
-
- - delivery.price.rule.tree - delivery.price.rule - - - - - - - - - - delivery.sale.order.form.view.with_carrier - sale.order - - - - - - - - - -
-
-
- - - - - - - - - - recompute_delivery_price and is_delivery - - -
-
-
+ +
+
+
+ + + + + + + + + + recompute_delivery_price and is_delivery + + +
+