From 13b5c5ebf4a3d4fe60c66f806bb0f4b37bae2651 Mon Sep 17 00:00:00 2001
From: "Dylan Kiss (dyki)" <dyki@odoo.com>
Date: Wed, 17 May 2023 10:59:06 +0000
Subject: [PATCH] [FIX] account: no draft move name in fidu mode
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

By default all the draft moves that are not the first one in a period
get the name `/`, indicating it is in draft. In the UI the name field
is then just an uneditable `Draft` placeholder.

When quick edit mode is activated, we always show the text field for
move names to allow users to edit the sequence number beforehand.
However for all abovementioned draft moves, it would show `/` in the
text field, requiring the user to first delete that symbol before
entering the right sequence.

This commit makes sure the names of draft moves without a sequence
number are empty (no `/`), so that in the UI the text field can be
filled out immediately and a placeholder `Draft` is shown.

task-3326827

closes odoo/odoo#124186

X-original-commit: 83a7daa07fedcaeddb983a94a86e4c7a187915d9
Signed-off-by: William André (wan) <wan@odoo.com>
---
 addons/account/models/account_move.py       |  4 +--
 addons/account/tests/test_sequence_mixin.py | 38 +++++++++++++++++++++
 2 files changed, 40 insertions(+), 2 deletions(-)

diff --git a/addons/account/models/account_move.py b/addons/account/models/account_move.py
index 3e192dd21d1..c1db0e5a903 100644
--- a/addons/account/models/account_move.py
+++ b/addons/account/models/account_move.py
@@ -739,7 +739,7 @@ class AccountMove(models.Model):
                     if move._get_last_sequence():
                         # The name does not match the date and the move is not the first in the period:
                         # Reset to draft
-                        move.name = '/'
+                        move.name = False
                         continue
                 else:
                     if move_has_name and move.posted_before or not move_has_name and move._get_last_sequence():
@@ -751,7 +751,7 @@ class AccountMove(models.Model):
             if move.date and (not move_has_name or not move._sequence_matches_date()):
                 move._set_next_sequence()
 
-        self.filtered(lambda m: not m.name).name = '/'
+        self.filtered(lambda m: not m.name and not move.quick_edit_mode).name = '/'
         self._inverse_name()
 
 
diff --git a/addons/account/tests/test_sequence_mixin.py b/addons/account/tests/test_sequence_mixin.py
index 3eede3718e4..ea39ea49f61 100644
--- a/addons/account/tests/test_sequence_mixin.py
+++ b/addons/account/tests/test_sequence_mixin.py
@@ -118,6 +118,44 @@ class TestSequenceMixin(TestSequenceMixinCommon):
             invoice_form.date = '2017-01-01'
             self.assertEqual(invoice_form.name, 'INV/2017/00001')
 
+    def test_sequence_empty_editable_with_quick_edit_mode(self):
+        """ Ensure the names of all but the first moves in a period are empty and editable in quick edit mode """
+        self.env.company.quick_edit_mode = 'in_invoices'
+
+        bill_1 = self.env['account.move'].create({
+            'partner_id': 1,
+            'move_type': 'in_invoice',
+            'date': '2016-01-01',
+            'line_ids': [
+                Command.create({
+                    'name': 'line',
+                    'account_id': self.company_data['default_account_revenue'].id,
+                }),
+            ]
+        })
+        # First move in a period gets a name
+        self.assertEqual(bill_1.name, 'BILL/2016/01/0001')
+
+        bill_2 = bill_1.copy({'date': '2016-01-02'})
+        with Form(bill_2) as bill_2_form:
+            # Subsequent moves in the same period get an empty editable name in draft mode
+            self.assertFalse(bill_2_form.name)
+            bill_2_form.name = 'BILL/2016/01/0002'
+            self.assertEqual(bill_2_form.name, 'BILL/2016/01/0002')
+
+
+        bill_3 = bill_1.copy({'date': '2016-01-03'})
+        bill_4 = bill_1.copy({'date': '2016-01-04'})
+        (bill_3 + bill_4).date = fields.Date.from_string('2016-02-01')
+
+        # Same works with updating multiple moves
+        with Form(bill_3) as bill_3_form:
+            self.assertEqual(bill_3_form.name, 'BILL/2016/02/0001')
+
+        with Form(bill_4) as bill_4_form:
+            self.assertFalse(bill_4_form.name)
+            bill_4_form.name = 'BILL/2016/02/0002'
+            self.assertEqual(bill_4_form.name, 'BILL/2016/02/0002')
 
     def test_sequence_draft_change_date(self):
         # When a draft entry is added to an empty period, it should get a name.