From 133f4da8446c6940db4a98982d5da71dcd86728d Mon Sep 17 00:00:00 2001
From: pash-odoo <pash@odoo.com>
Date: Wed, 12 Jul 2023 15:00:36 +0530
Subject: [PATCH] [FIX] hr_skills: fix resume end date wrong selection

before this commit, in resume we are able to put end date less than start date
which is not possible in real life.
inside form view add daterange widget to start date field so user not able to
select end date less than start date. switch the position of Display Type and
Certification or Course field to show the additional field below the Display
type when Display type is selected.

task-3397726

closes odoo/odoo#128269

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
---
 addons/hr_skills/views/hr_views.xml            | 4 ++--
 addons/hr_skills_slides/views/hr_templates.xml | 2 +-
 addons/hr_skills_survey/views/hr_templates.xml | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/hr_skills/views/hr_views.xml b/addons/hr_skills/views/hr_views.xml
index 7a42e173563..2025531f942 100644
--- a/addons/hr_skills/views/hr_views.xml
+++ b/addons/hr_skills/views/hr_views.xml
@@ -47,8 +47,8 @@
                             <field name="display_type" required="1"/>
                         </group>
                         <group>
-                            <field name="date_start" required="True"/>
-                            <field name="date_end"/>
+                            <field name="date_start" string="Duration" widget="daterange" options="{'end_date_field': 'date_end'}"/>
+                            <field name="date_end" invisible="1"/>
                         </group>
                     </group>
                     <field name="description" placeholder="Description"/>
diff --git a/addons/hr_skills_slides/views/hr_templates.xml b/addons/hr_skills_slides/views/hr_templates.xml
index 32eabb3511e..8bc5452ace9 100644
--- a/addons/hr_skills_slides/views/hr_templates.xml
+++ b/addons/hr_skills_slides/views/hr_templates.xml
@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="hr_skills.resume_line_view_form"/>
         <field eval="20" name="priority"/>
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='line_type_id']" position="after">
+            <xpath expr="//field[@name='display_type']" position="after">
                 <field name="channel_id"
                     readonly="0"
                     invisible="display_type != 'course'"/>
diff --git a/addons/hr_skills_survey/views/hr_templates.xml b/addons/hr_skills_survey/views/hr_templates.xml
index 2dd3c6d3998..8527d93e66b 100644
--- a/addons/hr_skills_survey/views/hr_templates.xml
+++ b/addons/hr_skills_survey/views/hr_templates.xml
@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="hr_skills.resume_line_view_form"/>
         <field eval="20" name="priority"/>
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='line_type_id']" position="after">
+            <xpath expr="//field[@name='display_type']" position="after">
                 <field name="survey_id"
                     domain="[('certification', '=', True)]"
                     readonly="0"