From 1331165c0f2a164ec0b4fdb6db72c303fddfc938 Mon Sep 17 00:00:00 2001 From: "Michael (mcm)" Date: Fri, 17 Sep 2021 09:21:28 +0000 Subject: [PATCH] [FIX] web: fix error stack undefined MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In javascript, Error.stack is not standard so it could be undefined on some browsers. This commit fixes possible crashes when we perform some operations on error.stack. closes odoo/odoo#76917 X-original-commit: f8bc701e78b31f90a30baebe734290f6202a0af9 Signed-off-by: Géry Debongnie (ged) Signed-off-by: Aaron Bohy (aab) --- addons/web/static/src/core/errors/error_utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/core/errors/error_utils.js b/addons/web/static/src/core/errors/error_utils.js index e6d3be23f8e..491c90e4ea9 100644 --- a/addons/web/static/src/core/errors/error_utils.js +++ b/addons/web/static/src/core/errors/error_utils.js @@ -29,7 +29,7 @@ export function formatTraceback(error) { // _onOpenFormView@http://localhost:8069/web/content/425-baf33f1/web.assets.js:1064:30 // ... traceback = `${errorName}: ${error.message}\n${error.stack}`.replace(/\n/g, "\n "); - } else { + } else if (error.stack) { // Chromium stack starts with the error's name but the name is "Error" by default // so we replace it to have the error type name traceback = error.stack.replace(/^[^:]*/g, errorName);