From 13222fcd685472d038503a1a35386eba686b13be Mon Sep 17 00:00:00 2001
From: Suraj Shukla <suh@odoo.com>
Date: Tue, 18 Dec 2018 07:09:14 +0000
Subject: [PATCH] [IMP] web: better ModelFieldSelector layout

This commit improves the usability of ModelFieldSelector widget
with following points:
- add a placeholder on the input for searching fields
- add more height to the same input for consistency
- properly show 'X' sign within header

Task 1916583
---
 addons/web/static/src/scss/model_field_selector.scss | 8 +++++---
 addons/web/static/src/xml/base.xml                   | 4 ++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/addons/web/static/src/scss/model_field_selector.scss b/addons/web/static/src/scss/model_field_selector.scss
index 2f778eddbb9..46d7d0b27b8 100644
--- a/addons/web/static/src/scss/model_field_selector.scss
+++ b/addons/web/static/src/scss/model_field_selector.scss
@@ -63,14 +63,16 @@
                 }
                 .o_field_selector_search {
                     padding-right: 0.4rem;
+                    > .o_input {
+                        padding: 5px 0.4rem;
+                    }
                 }
                 .o_field_selector_popover_option {
                     @include o-position-absolute($top: 0);
-                    padding: 7px 8px 8px 6px;
+                    padding: 8px;
 
-                    &.o_prev_page {
+                    &.o_field_selector_prev_page {
                         left: 0;
-                        border-right: 1px solid darken(theme-color('primary'), 10%);
                     }
                     &.o_field_selector_close {
                         right: 0;
diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml
index f9db8432275..f2b7c9653c6 100644
--- a/addons/web/static/src/xml/base.xml
+++ b/addons/web/static/src/xml/base.xml
@@ -749,8 +749,8 @@
             <i class="fa fa-arrow-left o_field_selector_popover_option o_field_selector_prev_page" title="Previous" role="img" aria-label="Previous"/>
             <div class="o_field_selector_title"/>
             <i class="fa fa-times o_field_selector_popover_option o_field_selector_close" title="Close" role="img" aria-label="Close"/>
-            <div t-if="widget.options.showSearchInput" class="o_field_selector_search">
-                <input type="text" class="o_input"/>
+            <div t-if="widget.options.showSearchInput" class="o_field_selector_search mt-2">
+                <input type="text" placeholder='Search...' class="o_input"/>
             </div>
         </div>
         <div class="o_field_selector_popover_body">