diff --git a/addons/mrp/mrp.py b/addons/mrp/mrp.py index 9151c150983..fa2dfedff49 100644 --- a/addons/mrp/mrp.py +++ b/addons/mrp/mrp.py @@ -1151,11 +1151,9 @@ class mrp_production(osv.osv): for line in production.product_lines: if line.product_id.type != 'service': stock_move_id = self._make_production_consume_line(cr, uid, line, context=context) + stock_moves.append(stock_move_id) else: self._make_service_procurement(cr, uid, line, context=context) - stock_move_id = False - if stock_move_id: - stock_moves.append(stock_move_id) if stock_moves: self.pool.get('stock.move').action_confirm(cr, uid, stock_moves, context=context) production.write({'state': 'confirmed'}, context=context) diff --git a/addons/sale/sale.py b/addons/sale/sale.py index 977d527b591..f59e8e93fa2 100644 --- a/addons/sale/sale.py +++ b/addons/sale/sale.py @@ -819,6 +819,7 @@ class sale_order_line(osv.osv): for line in self.browse(cr, uid, ids, context=context): if prod_obj.need_procurement(cr, uid, [line.product_id.id], context=context): return True + return False def _amount_line(self, cr, uid, ids, field_name, arg, context=None): tax_obj = self.pool.get('account.tax')