From 121c240dfda61746576f9fd965b40baa087ebcd2 Mon Sep 17 00:00:00 2001
From: Fabio Barbero <faba@odoo.com>
Date: Tue, 31 May 2022 14:12:37 +0000
Subject: [PATCH] [IMP] knowledge: merge read only and edit article template

Purpose
=======
Clean up templates to avoid duplicate code for article sidebar.

Task-2852908

Part-of: odoo/odoo#91430
---
 .../views/knowledge_templates_common.xml      | 41 ++++++-------------
 1 file changed, 13 insertions(+), 28 deletions(-)

diff --git a/addons/knowledge/views/knowledge_templates_common.xml b/addons/knowledge/views/knowledge_templates_common.xml
index 406f3c35d63..a853f7fa40b 100644
--- a/addons/knowledge/views/knowledge_templates_common.xml
+++ b/addons/knowledge/views/knowledge_templates_common.xml
@@ -30,8 +30,7 @@
                         <i t-if="article.child_ids" t-att-class="'align-self-center fa fa-fw fa-caret-' + ('down' if article.id in unfolded_articles else 'right')"/>
                         <i t-else="" class="pl-3 align-self-center"/>
                     </button>
-                    <t t-if="not readonly" t-call="knowledge.articles_template_name_editable"/>
-                    <t t-else="" t-call="knowledge.articles_template_name_readonly"/>
+                    <t t-call="knowledge.articles_template_name"/>
                 </div>
                 <ul t-if="not hideChildren and article.child_ids and article.id in unfolded_articles">
                     <t t-call="knowledge.articles_template">
@@ -42,40 +41,26 @@
         </t>
     </template>
 
-    <template id="articles_template_name_editable">
-        <div class="o_article_emoji_dropdown dropdown" t-att-data-article-id="article.id">
-            <a t-attf-class="o_article_emoji p-1 {{'o_article_emoji_active text-900' if isActive else ''}}" type="button"
-                t-attf-id="o_article_emoji_dropdown_#{article.id}" data-toggle="dropdown" aria-expanded="true"
-                t-if="not article.is_locked">
-                <t t-if="article.icon" t-out="article.icon"/>
-                <t t-else="">📄</t>
-            </a>
-            <a t-else="" class="p-1">
-                <t t-if="article.icon" t-out="article.icon"/>
-                <t t-else="">📄</t>
-            </a>
-            <div class="o_article_emoji_dropdown_panel dropdown-menu rounded p-0" role="menu"
-                t-attf-aria-labelledby="o_article_emoji_dropdown_#{article.id}"/>
-        </div>
-        <div class="o_article_name flex-grow-1 text-truncate o_cursor_pointer" t-out="article.name"/>
-        <button t-if="not hideChildren" class="o_article_create btn p-0 opacity-75 opacity-100-hover" type="button">
-            <i class="fa fa-fw fa-plus" title="Create a nested article" />
-        </button>
-    </template>
-
-    <template id="articles_template_name_readonly">
+    <template id="articles_template_name">
         <t t-if="not portal_readonly_mode">
             <div class="o_article_emoji_dropdown dropdown" t-att-data-article-id="article.id">
-                <a class="p-1">
+                <a t-attf-class="o_article_emoji p-1 {{'o_article_emoji_active text-900' if isActive else ''}}" type="button"
+                    t-attf-id="o_article_emoji_dropdown_#{article.id}" data-toggle="dropdown" aria-expanded="true"
+                    t-if="not readonly and not article.is_locked">
+                    <t t-if="article.icon" t-out="article.icon"/>
+                    <t t-else="">📄</t>
+                </a>
+                <a t-else="" class="p-1">
                     <t t-if="article.icon" t-out="article.icon"/>
                     <t t-else="">📄</t>
                 </a>
                 <div class="o_article_emoji_dropdown_panel dropdown-menu rounded p-0" role="menu"
                     t-attf-aria-labelledby="o_article_emoji_dropdown_#{article.id}"/>
             </div>
-            <div class="o_article_name flex-grow-1 text-truncate o_cursor_pointer">
-                <t t-out="article.name"/>
-            </div>
+            <div class="o_article_name flex-grow-1 text-truncate o_cursor_pointer" t-out="article.name"/>
+            <button t-if="not hideChildren and not readonly" class="o_article_create btn p-0 opacity-75 opacity-100-hover" type="button">
+                <i class="fa fa-fw fa-plus" title="Create a nested article" />
+            </button>
         </t>
         <div class="o_article_name flex-grow-1 text-truncate o_cursor_pointer" t-else="">
             <a t-out="article.display_name" t-attf-href="/knowledge/article/{{article.id}}" class="text-decoration-none"/>