From 11f6b294bdcfb82b1493fddf153de60c89df9ebf Mon Sep 17 00:00:00 2001
From: Nirali Sapra <nsa@odoo.com>
Date: Tue, 19 Dec 2017 14:48:22 +0100
Subject: [PATCH] [IMP] mail: don't delete in-use activity types, archive them
 instead

---
 addons/mail/models/mail_activity.py       |  3 ++-
 addons/mail/views/mail_activity_views.xml | 16 ++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/addons/mail/models/mail_activity.py b/addons/mail/models/mail_activity.py
index a385b66bf1f..b6707e0704e 100644
--- a/addons/mail/models/mail_activity.py
+++ b/addons/mail/models/mail_activity.py
@@ -19,6 +19,7 @@ class MailActivityType(models.Model):
     name = fields.Char('Name', required=True, translate=True)
     summary = fields.Char('Summary', translate=True)
     sequence = fields.Integer('Sequence', default=10)
+    active = fields.Boolean(default=True)
     days = fields.Integer(
         '# Days', default=0,
         help='Number of days before executing the action. It allows to plan the action deadline.')
@@ -71,7 +72,7 @@ class MailActivity(models.Model):
     # activity
     activity_type_id = fields.Many2one(
         'mail.activity.type', 'Activity',
-        domain="['|', ('res_model_id', '=', False), ('res_model_id', '=', res_model_id)]")
+        domain="['|', ('res_model_id', '=', False), ('res_model_id', '=', res_model_id)]", ondelete='restrict')
     activity_category = fields.Selection(related='activity_type_id.category')
     icon = fields.Char('Icon', related='activity_type_id.icon')
     summary = fields.Char('Summary')
diff --git a/addons/mail/views/mail_activity_views.xml b/addons/mail/views/mail_activity_views.xml
index 5e9906cc416..f5548d8ca4d 100644
--- a/addons/mail/views/mail_activity_views.xml
+++ b/addons/mail/views/mail_activity_views.xml
@@ -6,6 +6,11 @@
         <field name="arch" type="xml">
             <form string="Activities">
                 <sheet>
+                    <div class="oe_button_box" name="button_box">
+                        <button class="oe_stat_button" type="object" name="toggle_active" icon="fa-archive">
+                            <field name="active" widget="boolean_button" options='{"terminology": "archive"}'/>
+                        </button>
+                    </div>
                     <div class="oe_title">
                         <label for="name" class="oe_edit_only"/>
                         <h1><field name="name"/></h1>
@@ -27,6 +32,17 @@
         </field>
     </record>
 
+    <record id="mail_activity_type_view_search" model="ir.ui.view">
+        <field name="name">mail.activity.type.search</field>
+        <field name="model">mail.activity.type</field>
+        <field name="arch" type="xml">
+            <search string="Activities">
+                <field name="name"/>
+                <filter string="Archived" domain="[('active', '=', False)]" name="archived"/>
+            </search>
+        </field>
+    </record>
+
     <record id="mail_activity_type_view_tree" model="ir.ui.view">
         <field name="name">mail.activity.type.view.tree</field>
         <field name="model">mail.activity.type</field>