diff --git a/odoo/addons/test_new_api/models/test_new_api.py b/odoo/addons/test_new_api/models/test_new_api.py index 267e5157a3d..c8a5d6fd3a1 100644 --- a/odoo/addons/test_new_api/models/test_new_api.py +++ b/odoo/addons/test_new_api/models/test_new_api.py @@ -1783,3 +1783,21 @@ class EmptyChar(models.Model): _description = 'A model to test emtpy char' name = fields.Char('Name') + + +class Team(models.Model): + _name = 'test_new_api.team' + _description = 'Odoo Team' + + name = fields.Char() + parent_id = fields.Many2one('test_new_api.team') + member_ids = fields.One2many('test_new_api.team.member', 'team_id') + + +class TeamMember(models.Model): + _name = 'test_new_api.team.member' + _description = 'Odoo Developer' + + name = fields.Char('Name') + team_id = fields.Many2one('test_new_api.team') + parent_id = fields.Many2one('test_new_api.team', related='team_id.parent_id') diff --git a/odoo/addons/test_new_api/security/ir.model.access.csv b/odoo/addons/test_new_api/security/ir.model.access.csv index 0802c765e50..c49d35e6969 100644 --- a/odoo/addons/test_new_api/security/ir.model.access.csv +++ b/odoo/addons/test_new_api/security/ir.model.access.csv @@ -108,3 +108,5 @@ access_test_new_api_lesson,access_test_new_api_lesson,model_test_new_api_lesson, access_test_new_api_person,access_test_new_api_person,model_test_new_api_person,base.group_user,1,1,1,1 access_test_new_api_employer,access_test_new_api_employer,model_test_new_api_employer,base.group_user,1,1,1,1 public_access_test_new_api_course,access_test_new_api_course,model_test_new_api_course,base.group_public,1,0,0,0 +access_test_new_api_team,access_test_new_api_team,model_test_new_api_team,base.group_user,1,0,0,0 +access_test_new_api_team_member,access_test_new_api_team_member,model_test_new_api_team_member,base.group_user,1,0,0,0 diff --git a/odoo/addons/test_new_api/tests/test_one2many.py b/odoo/addons/test_new_api/tests/test_one2many.py index 50b7e48b569..814690f9864 100644 --- a/odoo/addons/test_new_api/tests/test_one2many.py +++ b/odoo/addons/test_new_api/tests/test_one2many.py @@ -409,3 +409,28 @@ class One2manyCase(TransactionCase): self.assertEqual(len(parent.child_ids), 3) self.assertEqual(parent, parent.child_ids.parent_id) self.assertEqual(parent.child_ids.mapped('name'), ['C3', 'PO', 'R2D2']) + + def test_parent_id(self): + Team = self.env['test_new_api.team'] + Member = self.env['test_new_api.team.member'] + + team1 = Team.create({'name': 'ORM'}) + team2 = Team.create({'name': 'Bugfix', 'parent_id': team1.id}) + team3 = Team.create({'name': 'Support', 'parent_id': team2.id}) + + Member.create({'name': 'Raphael', 'team_id': team1.id}) + member2 = Member.create({'name': 'Noura', 'team_id': team3.id}) + Member.create({'name': 'Ivan', 'team_id': team2.id}) + + # In this specific case... + self.assertEqual(member2.id, member2.team_id.parent_id.id) + + # ...we had an infinite recursion on making the following search. + with self.assertRaises(ValueError): + Team.search([('member_ids', 'child_of', member2.id)]) + + # Also, test a simple infinite loop if record is marked as a parent of itself + team1.parent_id = team1.id + # Check that the search is not stuck in the loop + Team.search([('id', 'parent_of', team1.id)]) + Team.search([('id', 'child_of', team1.id)]) diff --git a/odoo/osv/expression.py b/odoo/osv/expression.py index c9371b91112..80578027dfa 100644 --- a/odoo/osv/expression.py +++ b/odoo/osv/expression.py @@ -878,11 +878,13 @@ class expression(object): # filtering of forbidden records is done by the rest of the # domain parent_name = parent or left_model._parent_name + if (left_model._name != left_model._fields[parent_name].comodel_name): + raise ValueError(f"Invalid parent field: {left_model._fields[parent_name]}") child_ids = set() records = left_model.sudo().browse(ids) while records: child_ids.update(records._ids) - records = records.search([(parent_name, 'in', records.ids)], order='id') + records = records.search([(parent_name, 'in', records.ids)], order='id') - records.browse(child_ids) domain = [('id', 'in', list(child_ids))] if prefix: return [(left, 'in', left_model._search(domain))] @@ -910,7 +912,7 @@ class expression(object): records = left_model.sudo().browse(ids) while records: parent_ids.update(records._ids) - records = records[parent_name] + records = records[parent_name] - records.browse(parent_ids) domain = [('id', 'in', list(parent_ids))] if prefix: return [(left, 'in', left_model._search(domain))]