From 0fd5eaca7db492789738f91f1aa0c1dd1a9bd0fa Mon Sep 17 00:00:00 2001
From: "rpa (Open ERP)" <rpa@openerp.co.in>
Date: Thu, 7 Jan 2010 19:31:56 +0530
Subject: [PATCH] [FIX]: crm, caldav: Major changes regarding better user
 interface , change case of data from capital

bzr revid: rpa@openerp.co.in-20100107140156-jzewy27a4d9akgkv
---
 addons/caldav/caldav_data.xml |  48 ++++++++--------
 addons/caldav/caldav_view.xml |  16 +++---
 addons/caldav/calendar.py     |  38 ++++++-------
 addons/caldav/common.py       | 100 +++++++++++++++++-----------------
 4 files changed, 101 insertions(+), 101 deletions(-)

diff --git a/addons/caldav/caldav_data.xml b/addons/caldav/caldav_data.xml
index ab6ef5fcc38..2b942d3b9ff 100644
--- a/addons/caldav/caldav_data.xml
+++ b/addons/caldav/caldav_data.xml
@@ -6,8 +6,8 @@
 			<field name="name">1 minute before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="1" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -15,8 +15,8 @@
 			<field name="name">5 minutes before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="5" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -24,8 +24,8 @@
 			<field name="name">10 minutes before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="10" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -33,8 +33,8 @@
 			<field name="name">15 minutes before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="15" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -42,8 +42,8 @@
 			<field name="name">30 minutes before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="30" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -51,8 +51,8 @@
 			<field name="name">45 minutes before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="45" />
-			<field name="trigger_interval">MINUTES</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">minutes</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -60,8 +60,8 @@
 			<field name="name">1 hour before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="1" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -69,8 +69,8 @@
 			<field name="name">2 hours before</field>
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="2" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -79,8 +79,8 @@
 			
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="3" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -89,8 +89,8 @@
 			
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="4" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -99,8 +99,8 @@
 			
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="5" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
@@ -109,8 +109,8 @@
 			
 			<field name="active" eval="1" />
 			<field name="trigger_duration" eval="18" />
-			<field name="trigger_interval">HOURS</field>
-			<field name="trigger_occurs">BEFORE</field>
+			<field name="trigger_interval">hours</field>
+			<field name="trigger_occurs">before</field>
 			<field name="trigger_related">start</field>
 		</record>
 
diff --git a/addons/caldav/caldav_view.xml b/addons/caldav/caldav_view.xml
index 6335e4ce466..3dc58a6a765 100644
--- a/addons/caldav/caldav_view.xml
+++ b/addons/caldav/caldav_view.xml
@@ -63,19 +63,19 @@
 	                        <field name="state" select="2" />
 	                        <button name="do_tentative"
 	                        	string="Uncertain"
-	                        	states="NEEDS-ACTION" type="object"
+	                        	states="needs-action" type="object"
 	                        	icon="terp-crm" />
 	                        <button name="do_accept"
 	                        	string="Accept"
-	                        	states="NEEDS-ACTION" type="object"
+	                        	states="needs-action" type="object"
 	                        	icon="gtk-apply" />
 	                        <button name="do_decline"
 	                        	string="Decline"
-	                        	states="NEEDS-ACTION" type="object"
+	                        	states="needs-action" type="object"
 	                        	icon="gtk-cancel" />
 	                        <button
 	                        	name="%(caldav.action_view_calendar_invite_attendee_wizard)d"
-	                        	states="NEEDS-ACTION" string="Delegate"
+	                        	states="needs-action" string="Delegate"
 	                        	type="action" icon="gtk-sort-descending"
 	                        	context="{'model' : 'calendar.attendee'}" />
             		</group>
@@ -206,7 +206,7 @@
                     <field name="end_date"
                     	attrs="{'required' : [('count','&lt;=',0), ('freq', '!=', 'None')]}"/>
                     <group col="7" colspan="4" name="Select weekdays"
-                    		attrs="{'invisible' : [('freq','!=','WEEKLY')]}">
+                    		attrs="{'invisible' : [('freq','!=','weekly')]}">
                     	<separator string="" colspan="6" />
                     	<newline />
                     	<field name="mo" colspan="1" />
@@ -218,7 +218,7 @@
                     	<field name="su" colspan="1" />
                     	<newline />
                     </group>
-                    <group col="4" colspan="4" attrs="{'invisible' : [('freq','!=','MONTHLY'), ('freq','!=','YEARLY')]}">
+                    <group col="4" colspan="4" attrs="{'invisible' : [('freq','!=','monthly'), ('freq','!=','yearly')]}">
                     	<separator string="" colspan="6"/>
                     	<group col="2" colspan="4">
                     		<field name="select1"/>
@@ -236,9 +236,9 @@
                     		<label string="of the Month" />
                     		<newline />
                     	</group>
-                    	<group col="2" colspan="4" attrs="{'invisible' : [('freq','!=','YEARLY')]}">
+                    	<group col="2" colspan="4" attrs="{'invisible' : [('freq','!=','yearly')]}">
                     		<field name="month_list" string="of" colspan="1"
-                    				attrs="{'required' : [('freq','=','YEARLY')]}"/>
+                    				attrs="{'required' : [('freq','=','yearly')]}"/>
                  		</group>
                     </group>
                     <separator string="" colspan="6" />
diff --git a/addons/caldav/calendar.py b/addons/caldav/calendar.py
index 4a0e84268dd..6ff145a7a82 100644
--- a/addons/caldav/calendar.py
+++ b/addons/caldav/calendar.py
@@ -224,7 +224,7 @@ class Event(CalDAV, osv.osv_memory):
         'exrule': None, # Use: O-n, Type: RECUR, Defines a rule or repeating pattern for an exception to a recurrence set.
         'rstatus': None, 
         'related': None, # Use: O-n, Specify the relationship of the alarm trigger with respect to the start or end of the calendar component.
-                                #  like A trigger set 5 minutes after the end of the event or to-do.---> TRIGGER;RELATED=END:PT5M
+                                #  like A trigger set 5 minutes after the end of the event or to-do.---> TRIGGER;related=END:PT5M
         'resources': None, # Use: O-n, Type: TEXT, Defines the equipment or resources anticipated for an activity specified by a calendar entity like RESOURCES:EASEL,PROJECTOR,VCR, LANGUAGE=fr:1 raton-laveur
         'rdate': None, # Use: O-n, Type: DATE-TIME, Defines the list of date/times for a recurrence set.
         'rrule': None, # Use: O-n, Type: RECUR, Defines a rule or repeating pattern for recurring events, to-dos, or time zone definitions.
@@ -320,7 +320,7 @@ class Alarm(CalDAV, osv.osv_memory):
     'description': None, #      Type: Text, Provides a more complete description of the calendar component, than that provided by the "SUMMARY" property. Use:- R-1 for DISPLAY,Use:- R-1 for EMAIL,Use:- R-1 for PROCEDURE
     'summary': None, # Use: R-1, Type: Text        Which contains the text to be used as the message subject. Use for EMAIL
     'attendee': None, # Use: R-n, Type: CAL-ADDRESS, Contain the email address of attendees to receive the message. It can also include one or more. Use for EMAIL
-    'trigger': None, # Use: R-1, Type: DURATION, The "TRIGGER" property specifies a duration prior to the start of an event or a to-do. The "TRIGGER" edge may be explicitly set to be relative to the "START" or "END" of the event or to-do with the "RELATED" parameter of the "TRIGGER" property. The "TRIGGER" property value type can alternatively be set to an absolute calendar date and time of day value. Use for all action like AUDIO, DISPLAY, EMAIL and PROCEDURE
+    'trigger': None, # Use: R-1, Type: DURATION, The "TRIGGER" property specifies a duration prior to the start of an event or a to-do. The "TRIGGER" edge may be explicitly set to be relative to the "START" or "END" of the event or to-do with the "related" parameter of the "TRIGGER" property. The "TRIGGER" property value type can alternatively be set to an absolute calendar date and time of day value. Use for all action like AUDIO, DISPLAY, EMAIL and PROCEDURE
     'duration': None, #           Type: DURATION, Duration' and 'repeat' are both optional, and MUST NOT occur more than once each, but if one occurs, so MUST the other. Use:- 0-1 for AUDIO, EMAIL and PROCEDURE, Use:- 0-n for DISPLAY
     'repeat': None, #           Type: INTEGER, Duration' and 'repeat' are both optional, and MUST NOT occur more than once each, but if one occurs, so MUST the other. Use:- 0-1 for AUDIO, EMAIL and PROCEDURE, Use:- 0-n for DISPLAY
     'attach': None, # Use:- O-n: which MUST point to a sound resource, which is rendered when the alarm is triggered for AUDIO, Use:- O-n: which are intended to be sent as message attachments for EMAIL, Use:- R-1:which MUST point to a procedure resource, which is invoked when the alarm is triggered for PROCEDURE.
@@ -335,22 +335,22 @@ class Alarm(CalDAV, osv.osv_memory):
         # Compute trigger data
         interval = alarm_data['trigger_interval']
         occurs = alarm_data['trigger_occurs']
-        duration = (occurs == 'AFTER' and alarm_data['trigger_duration']) \
+        duration = (occurs == 'after' and alarm_data['trigger_duration']) \
                                             or -(alarm_data['trigger_duration'])
         related = alarm_data['trigger_related']
-        trigger = valarm.add('TRIGGER')
-        trigger.params['RELATED'] = [related.upper()]
-        if interval == 'DAYS':
+        trigger = valarm.add('trigger')
+        trigger.params['related'] = [related.upper()]
+        if interval == 'days':
             delta = timedelta(days=duration)
-        if interval == 'HOURS':
+        if interval == 'hours':
             delta = timedelta(hours=duration)
-        if interval == 'MINUTES':
+        if interval == 'minutes':
             delta = timedelta(minutes=duration)
         trigger.value = delta
 
         # Compute other details
-        valarm.add('DESCRIPTION').value = alarm_data['name']
-        valarm.add('ACTION').value = alarm_data['action']
+        valarm.add('description').value = alarm_data['name']
+        valarm.add('action').value = alarm_data['action']
         return vevent
         
     def import_ical(self, cr, uid, ical_data):
@@ -359,25 +359,25 @@ class Alarm(CalDAV, osv.osv_memory):
                 seconds = child.value.seconds
                 days = child.value.days
                 diff = (days * 86400) +  seconds
-                interval = 'DAYS'
-                related = 'BEFORE'
+                interval = 'days'
+                related = 'before'
                 if not seconds:
                     duration = abs(days)
-                    related = days>0 and 'AFTER' or 'BEFORE'
+                    related = days>0 and 'after' or 'before'
                 elif (abs(diff) / 3600) == 0:
                     duration = abs(diff / 60)
-                    interval = 'MINUTES'
-                    related = days>=0 and 'AFTER' or 'BEFORE'
+                    interval = 'minutes'
+                    related = days>=0 and 'after' or 'before'
                 else:
                     duration = abs(diff / 3600)
-                    interval = 'HOURS'
-                    related = days>=0 and 'AFTER' or 'BEFORE'
+                    interval = 'hours'
+                    related = days>=0 and 'after' or 'before'
                 self.ical_set('trigger_interval', interval, 'value')
                 self.ical_set('trigger_duration', duration, 'value')
                 self.ical_set('trigger_occurs', related, 'value')
                 if child.params:
-                    if child.params.get('RELATED'):
-                        self.ical_set('trigger_related', child.params.get('RELATED')[0].lower(), 'value')
+                    if child.params.get('related'):
+                        self.ical_set('trigger_related', child.params.get('related')[0].lower(), 'value')
             else:
                 self.ical_set(child.name.lower(), child.value, 'value')
         vals = map_data(cr, uid, self)
diff --git a/addons/caldav/common.py b/addons/caldav/common.py
index e655b5c3fb2..7bf380103f4 100644
--- a/addons/caldav/common.py
+++ b/addons/caldav/common.py
@@ -125,21 +125,21 @@ class calendar_attendee(osv.osv):
         return result 
     
     _columns = {
-        'cutype': fields.selection([('INDIVIDUAL', 'INDIVIDUAL'), \
-                    ('GROUP', 'GROUP'), ('RESOURCE', 'RESOURCE'), \
-                    ('ROOM', 'ROOM'), ('UNKNOWN', 'UNKNOWN') ], \
+        'cutype': fields.selection([('individual', 'Individual'), \
+                    ('group', 'Group'), ('resource', 'Resource'), \
+                    ('room', 'Room'), ('unknown', 'Unknown') ], \
                     'User Type', help="Specify the type of calendar user"), 
         'member': fields.char('Member', size=124, help="Indicate the groups \
 that the attendee belongs to"), 
-        'role': fields.selection([ ('REQ-PARTICIPANT', 'REQ-PARTICIPANT'), \
-                        ('CHAIR', 'CHAIR'), ('OPT-PARTICIPANT', 'OPT-PARTICIPANT'), \
-                        ('NON-PARTICIPANT', 'NON-PARTICIPANT')], 'User\'s Role', \
+        'role': fields.selection([ ('req-participant', 'req-participant'), \
+                        ('chair', 'chair'), ('opt-participant', 'opt-participant'), \
+                        ('non-participant', 'non-participant')], 'User\'s Role', \
                         help='Participation role for the calendar user'), 
-        'state': fields.selection([('TENTATIVE', 'Tentative'), 
-                        ('NEEDS-ACTION', 'Needs Action'), 
-                        ('ACCEPTED', 'Accepted'), 
-                        ('DECLINED', 'Declined'), 
-                        ('DELEGATED', 'Delegated')], 'Status', readonly=True, 
+        'state': fields.selection([('tentative', 'Tentative'), 
+                        ('needs-action', 'Needs Action'), 
+                        ('accepted', 'Accepted'), 
+                        ('declined', 'Declined'), 
+                        ('delegated', 'Delegated')], 'Status', readonly=True, 
                         help="Status of the attendee's participation"), 
         'rsvp':  fields.boolean('Required Reply?', help="Indicats whether the \
 favor of a reply is requested"), 
@@ -162,7 +162,7 @@ was delegated to"),
         'email': fields.char('Email', size=124),
                 }
     _defaults = {
-        'state':  lambda *x: 'NEEDS-ACTION', 
+        'state':  lambda *x: 'needs-action', 
         }
 
     def onchange_user_id(self, cr, uid, ids, user_id, *args, **argv):
@@ -172,13 +172,13 @@ was delegated to"),
         return {'value': {'email': user.address_id.email}}
 
     def do_tentative(self, cr, uid, ids, context=None, *args):
-        self.write(cr, uid, ids, {'state': 'TENTATIVE'}, context)
+        self.write(cr, uid, ids, {'state': 'tentative'}, context)
 
     def do_accept(self, cr, uid, ids, context=None, *args):
-        self.write(cr, uid, ids, {'state': 'ACCEPTED'}, context)
+        self.write(cr, uid, ids, {'state': 'accepted'}, context)
 
     def do_decline(self, cr, uid, ids, context=None, *args):
-        self.write(cr, uid, ids, {'state': 'DECLINED'}, context)
+        self.write(cr, uid, ids, {'state': 'declined'}, context)
 
 calendar_attendee()
 
@@ -187,10 +187,10 @@ class res_alarm(osv.osv):
     _description = 'basic alarm information'
     _columns = {      
         'name':fields.char('Name', size=256, required=True),          
-        'trigger_occurs': fields.selection([('BEFORE', 'BEFORE'), ('AFTER', 'AFTER')], \
+        'trigger_occurs': fields.selection([('before', 'Before'), ('after', 'After')], \
                                         'Trigger time', required=True), 
-        'trigger_interval': fields.selection([('MINUTES', 'MINUTES'), ('HOURS', 'HOURS'), \
-                ('DAYS', 'DAYS')], 'Trigger duration', required=True), 
+        'trigger_interval': fields.selection([('minutes', 'Minutes'), ('hours', 'Hours'), \
+                ('days', 'Days')], 'Trigger duration', required=True), 
         'trigger_duration':  fields.integer('Time', required=True), 
         'trigger_related':  fields.selection([('start', 'The event starts'), ('end', \
                                        'The event ends')], 'Trigger Occures at', required=True), 
@@ -202,9 +202,9 @@ are both optional, but if one occurs, so MUST the other"""),
         
     }
     _defaults = {        
-        'trigger_interval':  lambda *x: 'MINUTES', 
+        'trigger_interval':  lambda *x: 'minutes', 
         'trigger_duration': lambda *x: 5, 
-        'trigger_occurs': lambda *x: 'BEFORE', 
+        'trigger_occurs': lambda *x: 'before', 
         'trigger_related': lambda *x: 'start', 
         'active': lambda *x: 1, 
     }
@@ -230,27 +230,27 @@ class calendar_alarm(osv.osv):
     }
      
     _columns = {            
-            'name': fields.char('Summary', size=124, help="""Contains the text to be used as the message subject for EMAIL
-or contains the text to be used for DISPLAY"""), 
-            'action': fields.selection([('AUDIO', 'AUDIO'), ('DISPLAY', 'DISPLAY'), \
-                    ('PROCEDURE', 'PROCEDURE'), ('EMAIL', 'EMAIL') ], 'Action', \
+            'name': fields.char('Summary', size=124, help="""Contains the text to be used as the message subject for email
+or contains the text to be used for display"""), 
+            'action': fields.selection([('audio', 'Audio'), ('display', 'Display'), \
+                    ('procedure', 'Procedure'), ('email', 'Email') ], 'Action', \
                     required=True, help="Defines the action to be invoked when an alarm is triggered"), 
             'description': fields.text('Description', help='Provides a more complete description of the calendar component, than that provided by the "SUMMARY" property'), 
             'attendee_ids': fields.many2many('calendar.attendee', 'alarm_attendee_rel', \
                                           'alarm_id', 'attendee_id', 'Attendees', readonly=True), 
-            'trigger_occurs': fields.selection([('BEFORE', 'BEFORE'), ('AFTER', 'AFTER')], \
+            'trigger_occurs': fields.selection([('before', 'before'), ('after', 'after')], \
                                         'Trigger time', required=True), 
-            'trigger_interval': fields.selection([('MINUTES', 'MINUTES'), ('HOURS', 'HOURS'), \
-                    ('DAYS', 'DAYS')], 'Trigger duration', required=True), 
+            'trigger_interval': fields.selection([('minutes', 'minutes'), ('hours', 'hours'), \
+                    ('days', 'days')], 'Trigger duration', required=True), 
             'trigger_duration':  fields.integer('Time', required=True), 
             'trigger_related':  fields.selection([('start', 'The event starts'), ('end', \
                                            'The event ends')], 'Trigger Occures at', required=True), 
             'duration': fields.integer('Duration', help="""Duration' and 'Repeat' \
 are both optional, but if one occurs, so MUST the other"""), 
             'repeat': fields.integer('Repeat'), # TODO 
-            'attach': fields.binary('Attachment', help="""* Points to a sound resource, which is rendered when the alarm is triggered for AUDIO, 
-* File which is intended to be sent as message attachments for EMAIL,
-* Points to a procedure resource, which is invoked when the alarm is triggered for PROCEDURE."""), 
+            'attach': fields.binary('Attachment', help="""* Points to a sound resource, which is rendered when the alarm is triggered for audio, 
+* File which is intended to be sent as message attachments for email,
+* Points to a procedure resource, which is invoked when the alarm is triggered for procedure."""), 
             'res_id' : fields.integer('Resource ID'),
             'model_id': fields.many2one('ir.model', 'Model'),
             'user_id': fields.many2one('res.users', 'Owner'),
@@ -265,11 +265,11 @@ are both optional, but if one occurs, so MUST the other"""),
      }
 
     _defaults = {
-        'action':  lambda *x: 'EMAIL', 
+        'action':  lambda *x: 'email', 
         'state' : lambda *x: 'run',
-        'trigger_interval':  lambda *x: 'MINUTES', 
+        'trigger_interval':  lambda *x: 'minutes', 
         'trigger_duration': lambda *x: 5, 
-        'trigger_occurs': lambda *x: 'BEFORE', 
+        'trigger_occurs': lambda *x: 'before', 
         'trigger_related': lambda *x: 'start',         
      }   
 
@@ -277,13 +277,13 @@ are both optional, but if one occurs, so MUST the other"""),
         event_date = vals.get('event_date', False)
         if event_date:
             dtstart = datetime.datetime.strptime(vals['event_date'], "%Y-%m-%d %H:%M:%S")
-            if vals['trigger_interval'] == 'DAYS':
+            if vals['trigger_interval'] == 'days':
                 delta = datetime.timedelta(days=vals['trigger_duration'])
-            if vals['trigger_interval'] == 'HOURS':
+            if vals['trigger_interval'] == 'hours':
                 delta = datetime.timedelta(hours=vals['trigger_duration'])
-            if vals['trigger_interval'] == 'MINUTES':
+            if vals['trigger_interval'] == 'minutes':
                 delta = datetime.timedelta(minutes=vals['trigger_duration'])
-            trigger_date =  dtstart + (vals['trigger_occurs'] == 'AFTER' and delta or -delta)
+            trigger_date =  dtstart + (vals['trigger_occurs'] == 'after' and delta or -delta)
             vals['trigger_date'] = trigger_date
         res = super(calendar_alarm, self).create(cr, uid, vals, context)        
         return res
@@ -302,7 +302,7 @@ are both optional, but if one occurs, so MUST the other"""),
         request_obj = self.pool.get('res.request')
         mail_to = []
         for alarm in self.browse(cr, uid, alarm_ids):            
-            if alarm.action == 'DISPLAY':
+            if alarm.action == 'display':
                 value = {                   
                    'name': alarm.name,
                    'act_from': alarm.user_id.id,
@@ -319,7 +319,7 @@ are both optional, but if one occurs, so MUST the other"""),
                     request_ids.append(request_id)
                 request_obj.request_send(cr, uid, request_ids)
 
-            if alarm.action == 'EMAIL':
+            if alarm.action == 'email':
                 sub = '[Openobject Remainder] %s' %(alarm.name)    
                 body = """
                 Name : %s
@@ -428,13 +428,13 @@ class set_rrule_wizard(osv.osv_memory):
 
     _columns = {
         'freq': fields.selection([('None', 'No Repeat'), \
-                            ('SECONDLY', 'SECONDLY'), \
-                            ('MINUTELY', 'MINUTELY'), \
-                            ('HOURLY', 'HOURLY'), \
-                            ('DAILY', 'DAILY'), \
-                            ('WEEKLY', 'WEEKLY'), \
-                            ('MONTHLY', 'MONTHLY'), \
-                            ('YEARLY', 'YEARLY')], 'Frequency', required=True), 
+                            ('secondly', 'Secondly'), \
+                            ('minutely', 'Minutely'), \
+                            ('hourly', 'Hourly'), \
+                            ('daily', 'Daily'), \
+                            ('weekly', 'Weekly'), \
+                            ('monthly', 'Monthly'), \
+                            ('yearly', 'Yearly')], 'Frequency', required=True), 
         'interval': fields.integer('Interval'), 
         'count': fields.integer('Count'), 
         'mo': fields.boolean('Mon'), 
@@ -459,7 +459,7 @@ class set_rrule_wizard(osv.osv_memory):
     }
 
     _defaults = {
-                 'freq':  lambda *x: 'DAILY', 
+                 'freq':  lambda *x: 'daily', 
                  'select1':  lambda *x: 'date', 
                  'interval':  lambda *x: 1, 
                  }
@@ -477,12 +477,12 @@ class set_rrule_wizard(osv.osv_memory):
             obj.write(cr, uid, [res_obj.id], {'rrule' : ''})
             return {}
 
-        if freq == 'WEEKLY':
+        if freq == 'weekly':
             byday = map(lambda x: x.upper(), filter(lambda x: datas.get(x) and x in weekdays, datas))
             if byday: 
                 weekstring = ';BYDAY=' + ','.join(byday)
 
-        elif freq == 'MONTHLY':
+        elif freq == 'monthly':
             byday = ''
             if datas.get('select1')=='date'  and (datas.get('day') < 1 or datas.get('day') > 31):
                 raise osv.except_osv(_('Error!'), ("Please select proper Day of month"))
@@ -490,7 +490,7 @@ class set_rrule_wizard(osv.osv_memory):
                 byday = ';BYDAY=' + datas.get('byday') + datas.get('week_list')
             monthstring = byday or (';BYMONTHDAY=' + str(datas.get('day')))
 
-        elif freq == 'YEARLY':
+        elif freq == 'yearly':
             bymonth = ''
             byday = ''
             if datas.get('select1')=='date'  and (datas.get('day') < 1 or datas.get('day') > 31):