From 0f3ed1e09addc905b85c6188ef0b652782fcace3 Mon Sep 17 00:00:00 2001
From: Olivier Dony <odo@openerp.com>
Date: Fri, 26 Oct 2012 17:28:27 +0200
Subject: [PATCH] [IMP] portal_sale: better menu labels, add group to restrict
 visibility of payment options, improve module description

bzr revid: odo@openerp.com-20121026152827-iq5ku8q3atqisw6m
---
 addons/portal_sale/__openerp__.py             | 20 +++++++++++++---
 addons/portal_sale/portal_sale_view.xml       | 24 +++++++++----------
 .../portal_sale/security/portal_security.xml  | 12 ++++++++++
 3 files changed, 40 insertions(+), 16 deletions(-)

diff --git a/addons/portal_sale/__openerp__.py b/addons/portal_sale/__openerp__.py
index 8d7cd8b3935..ba5d25c56ed 100644
--- a/addons/portal_sale/__openerp__.py
+++ b/addons/portal_sale/__openerp__.py
@@ -26,8 +26,22 @@
     'category': 'Tools',
     'complexity': 'easy',
     'description': """
-This module adds sale menu and features to your portal if sale and portal are installed.
-========================================================================================
+This module adds a Sales menu to your portal as soon as sale and portal are installed.
+======================================================================================
+
+After installing this module, portal users will be able to access their own documents
+via the following menus:
+
+  - Quotations
+  - Sale Orders
+  - Delivery Orders
+  - Products (public ones)
+  - Invoices
+  - Payments/Refunds
+
+If online payment acquirers are configured, portal users will also be given the opportunity to
+pay online on their Sale Orders and Invoices that are not paid yet. Paypal is included
+by default, you simply need to configure a Paypal account in the Accounting settings.
     """,
     'author': 'OpenERP SA',
     'depends': ['sale_stock','portal'],
@@ -36,8 +50,8 @@ This module adds sale menu and features to your portal if sale and portal are in
         'portal_sale_view.xml',
         'security/ir.model.access.csv',
     ],
-    'installable': True,
     'auto_install': True,
     'category': 'Hidden',
 }
+
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/portal_sale/portal_sale_view.xml b/addons/portal_sale/portal_sale_view.xml
index f4607590717..e1c5a233eb9 100644
--- a/addons/portal_sale/portal_sale_view.xml
+++ b/addons/portal_sale/portal_sale_view.xml
@@ -8,7 +8,7 @@
                 <field name="inherit_id" ref="sale.view_order_form"/>
                 <field name="arch" type="xml">
                     <notebook version="7.0" position="before">
-                        <field name="portal_payment_options"/>
+                        <field name="portal_payment_options" groups="portal_sale.group_payment_options"/>
                     </notebook>
                 </field>
         </record>
@@ -29,7 +29,7 @@
         </record>
 
         <record id="action_order_form" model="ir.actions.act_window">
-            <field name="name">Sales Orders</field>
+            <field name="name">Sale Orders</field>
             <field name="type">ir.actions.act_window</field>
             <field name="res_model">sale.order</field>
             <field name="view_mode">tree,form,calendar,graph</field>
@@ -57,11 +57,11 @@
             <field name="view_mode">kanban,tree,form</field>
             <field name="view_id" ref="product.product_kanban_view"/>
             <field name="search_view_id" ref="product.product_search_form_view"/>
-            <field name="help">No public products.</field>
+            <field name="help">There are no public products.</field>
         </record>
 
         <record id="action_invoice_tree1" model="ir.actions.act_window">
-            <field name="name">Customer Invoices</field>
+            <field name="name">Invoices</field>
             <field name="res_model">account.invoice</field>
             <field name="view_mode">tree,form,calendar,graph</field>
             <field name="domain">[('type','=','out_invoice')]</field>
@@ -71,7 +71,7 @@
         </record>
 
         <record id="action_vendor_receipt" model="ir.actions.act_window">
-            <field name="name">Customer Payment</field>
+            <field name="name">Refunds/Payments</field>
             <field name="res_model">account.voucher</field>
             <field name="domain">[('journal_id.type', 'in', ['bank', 'cash']), ('type','=','receipt')]</field>
             <field name="context">{'type':'receipt'}</field>
@@ -80,19 +80,17 @@
             <field name="help">You don't have any payment.</field>
         </record>
 
-        <menuitem name="Quotations" id="portal_quotations" parent="portal.portal_orders"
+        <menuitem id="portal_quotations" parent="portal.portal_orders"
             action="action_order_tree5" sequence="10"/>
-        <menuitem name="Sales Orders" id="portal_sales_orders" parent="portal.portal_orders"
+        <menuitem id="portal_sales_orders" parent="portal.portal_orders"
             action="action_order_form" sequence="20"/>
-        <menuitem name="Delivery Orders" id="portal_delivery" parent="portal.portal_orders"
+        <menuitem id="portal_delivery" parent="portal.portal_orders"
             action="action_picking_tree" sequence="30"/>
-        <menuitem name="Products" id="portal_products" parent="portal.portal_orders"
+        <menuitem id="portal_products" parent="portal.portal_orders"
             action="product_normal_action" sequence="40"/>
-
-        <menuitem name="Invoice" id="portal_invoices" parent="portal.portal_invoices_payements"
+        <menuitem id="portal_invoices" parent="portal.portal_invoices_payements"
             action="action_invoice_tree1" sequence="10"/>
-        <menuitem name="Refund/Payments" id="portal_payments" parent="portal.portal_invoices_payements"
+        <menuitem id="portal_payments" parent="portal.portal_invoices_payements"
             action="action_vendor_receipt" sequence="20"/>
-
     </data>
 </openerp>
diff --git a/addons/portal_sale/security/portal_security.xml b/addons/portal_sale/security/portal_security.xml
index c4bf6131ba1..07fb49b64d6 100644
--- a/addons/portal_sale/security/portal_security.xml
+++ b/addons/portal_sale/security/portal_security.xml
@@ -2,6 +2,18 @@
 <openerp>
     <data noupdate="1">
 
+        <record id="group_payment_options" model="res.groups">
+            <field name="name">View Online Payment Options</field>
+            <field name="category_id" ref="base.module_category_hidden"/>
+            <field name="comment">Members of this group see the online payment options
+on Sale Orders and Customer Invoices. These options are meant for customers who are accessing
+their documents through the portal.</field>
+        </record>
+        <!-- Make the payment_options group implied for all portal users -->
+        <record id="portal.group_portal" model="res.groups">
+            <field name="implied_ids" eval="[(4,ref('group_payment_options'))]"/>
+        </record>
+
         <!-- Sale Portal Access Rules -->
         <record id="portal_sale_order_user_rule" model="ir.rule">
             <field name="name">Portal Personal Quotations/Sales Orders</field>