From 0d6bcd3918f6f99fcffc49925544c9de39b5f1ac Mon Sep 17 00:00:00 2001
From: Pierre Masereel <pim@odoo.com>
Date: Tue, 13 Nov 2018 09:50:00 +0000
Subject: [PATCH] [IMP] stock: scrap location internal or inventory

We restrict the case of locations that can be scrap locations to
locations of usage internal or inventory loss, depending on how you want
to manage your scrap. Other usage of location shouldn't be scrap
locations.

TASK-ID: 38469
---
 addons/stock/models/stock_location.py       | 5 +++++
 addons/stock/views/stock_location_views.xml | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/addons/stock/models/stock_location.py b/addons/stock/models/stock_location.py
index 4c9f32c3266..118a253398a 100644
--- a/addons/stock/models/stock_location.py
+++ b/addons/stock/models/stock_location.py
@@ -74,6 +74,11 @@ class Location(models.Model):
         else:
             self.complete_name = self.name
 
+    @api.onchange('usage')
+    def _onchange_usage(self):
+        if self.usage not in ('internal', 'inventory'):
+            self.scrap_location = False
+
     def write(self, values):
         if 'usage' in values and values['usage'] == 'view':
             if self.mapped('quant_ids'):
diff --git a/addons/stock/views/stock_location_views.xml b/addons/stock/views/stock_location_views.xml
index 70fb18ef887..b726d374970 100644
--- a/addons/stock/views/stock_location_views.xml
+++ b/addons/stock/views/stock_location_views.xml
@@ -35,7 +35,7 @@
                     <group string="Additional Information">
                         <field name="usage"/>
                         <field name="company_id" groups="base.group_multi_company" options="{'no_create': True}"/>
-                        <field name="scrap_location"/>
+                        <field name="scrap_location" attrs="{'invisible': [('usage', 'not in', ('inventory', 'internal'))]}"/>
                         <field name="return_location"/>
                     </group>
                     <group string="Localization" name="localization">