From 0d41a3cb81d4167d970502d5d49fed1deca0f625 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Baranx=20=28bar=29?= <bar@odoo.com>
Date: Thu, 27 Feb 2020 07:16:40 +0000
Subject: [PATCH] [FIX] sale: Traceback when creating a quote

The field 'type' in the account.move model has been renamed into 'move_type'
but the ir.rules of the sale module have not been updated.

The fix consists in renaming this field in ir.rules.

As another bug was due to this field renaming (see 51b70b6fc42), I have checked
that the old 'type' field is no more used in Odoo files.

closes odoo/odoo#46398

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/sale/security/sale_security.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/sale/security/sale_security.xml b/addons/sale/security/sale_security.xml
index aa82f6143fe..fb041d3768f 100644
--- a/addons/sale/security/sale_security.xml
+++ b/addons/sale/security/sale_security.xml
@@ -177,14 +177,14 @@
     <record id="account_invoice_line_rule_see_personal" model="ir.rule">
         <field name="name">Personal Invoice Lines</field>
         <field name="model_id" ref="model_account_move_line"/>
-        <field name="domain_force">[('move_id.type', 'in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund')), '|', ('move_id.invoice_user_id', '=', user.id), ('move_id.invoice_user_id', '=', False)]</field>
+        <field name="domain_force">[('move_id.move_type', 'in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund')), '|', ('move_id.invoice_user_id', '=', user.id), ('move_id.invoice_user_id', '=', False)]</field>
         <field name="groups" eval="[(4, ref('sales_team.group_sale_salesman'))]"/>
     </record>
 
     <record id="account_invoice_line_rule_see_all" model="ir.rule">
         <field name="name">All Invoice Lines</field>
         <field name="model_id" ref="model_account_move_line"/>
-        <field name="domain_force">[('move_id.type', 'in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund'))]</field>
+        <field name="domain_force">[('move_id.move_type', 'in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund'))]</field>
         <field name="groups" eval="[(4, ref('sales_team.group_sale_salesman_all_leads'))]"/>
     </record>