From 0cf2437f6735809d9e5cde1a4adaa0df06c5953d Mon Sep 17 00:00:00 2001 From: Stanislas Gueniffey Date: Mon, 8 May 2023 17:51:23 +0000 Subject: [PATCH] [IMP] web_editor: remove dead '_onInput' code The 'insertLineBreak' case in `onInput` is dead code because any event that might cause it (pressing Shift+Enter) first triggers `onKeydown`, which calls `ev.preventDefault()` and thus prevents it from reaching `onInput`. Task-3301232 closes odoo/odoo#121850 X-original-commit: c63cd2f0140959a7ac6e05ef15ac5c2ac552453d Signed-off-by: David Monjoie (dmo) --- .../static/src/js/editor/odoo-editor/src/OdooEditor.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js b/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js index 49cdbf303c3..152432c0402 100644 --- a/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js +++ b/addons/web_editor/static/src/js/editor/odoo-editor/src/OdooEditor.js @@ -3404,11 +3404,6 @@ export class OdooEditor extends EventTarget { } } this.historyStep(); - } else if (ev.inputType === 'insertLineBreak') { - this._compositionStep(); - this.historyRollback(); - ev.preventDefault(); - this._applyCommand('oShiftEnter'); } else { this.historyStep(); }