From 0cdfc84be862ecefc2eb9f567b2fd5adbf964f85 Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Thu, 23 Aug 2018 16:51:54 +0200 Subject: [PATCH] [FIX] base: fix authentication, wrong login/password raise an error 500 During rebase of 4f6ec1c, we remove accidently a part of aac21e4. Side effect is that uid was False but success_login True. Courtesy of @xmo-odoo for help --- odoo/addons/base/models/res_users.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/odoo/addons/base/models/res_users.py b/odoo/addons/base/models/res_users.py index 5a1e3624e4f..067aec82482 100644 --- a/odoo/addons/base/models/res_users.py +++ b/odoo/addons/base/models/res_users.py @@ -559,10 +559,11 @@ class Users(models.Model): self = api.Environment(cr, SUPERUSER_ID, {})[cls._name] with self._assert_can_auth(): user = self.search(self._get_login_domain(login)) - if user: - user = user.sudo(user.id) - user._check_credentials(password) - user._update_last_login() + if not user: + raise AccessDenied() + user = user.sudo(user.id) + user._check_credentials(password) + user._update_last_login() except AccessDenied: _logger.info("Login failed for db:%s login:%s from %s", db, login, ip) raise