From 0cdfae0e258f0a00687372c211e4ed541709bdec Mon Sep 17 00:00:00 2001 From: Simon Lejeune Date: Wed, 4 Apr 2018 16:49:24 +0200 Subject: [PATCH] [FIX] stock: _compute_show_operations Using `break` when looping over a recordset in a compute method could have side effects. Computed field are computed in batch, according to the order of the recordset, the value may only be computed correctly for some records related to rev c49356986699e39d2ee7ddccd4f3485fe6f47b1a opw-1833347 --- addons/stock/models/stock_picking.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/stock/models/stock_picking.py b/addons/stock/models/stock_picking.py index 0c0ee657e83..ee25c920199 100644 --- a/addons/stock/models/stock_picking.py +++ b/addons/stock/models/stock_picking.py @@ -315,7 +315,7 @@ class Picking(models.Model): for picking in self: if self.env.context.get('force_detailed_view'): picking.show_operations = True - break + continue if picking.picking_type_id.show_operations: if (picking.state == 'draft' and not self.env.context.get('planned_picking')) or picking.state != 'draft': picking.show_operations = True