From 0ca248892f045be740083ff546e9fdaee6ee2d50 Mon Sep 17 00:00:00 2001
From: Jeremy Kersten <jke@odoo.com>
Date: Wed, 25 Nov 2020 11:14:34 +0000
Subject: [PATCH] [FIX] website*: fix quick create (o_new_content) performance
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Before, on request by groups, now we use a variable is_system / is_designer
to make only once the request.

closes odoo/odoo#62313

Related: odoo/enterprise#14970
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
---
 .../views/website_navbar_templates.xml        | 142 +++++++++---------
 .../views/website_blog_templates.xml          |   2 +-
 .../website_event/views/website_templates.xml |   2 +-
 addons/website_forum/views/website_forum.xml  |   2 +-
 .../website_hr_recruitment_templates.xml      |   2 +-
 addons/website_sale/views/templates.xml       |   2 +-
 .../views/website_slides_templates_utils.xml  |   2 +-
 7 files changed, 78 insertions(+), 76 deletions(-)

diff --git a/addons/website/views/website_navbar_templates.xml b/addons/website/views/website_navbar_templates.xml
index 92c67ac5277..718b7cb52cd 100644
--- a/addons/website/views/website_navbar_templates.xml
+++ b/addons/website/views/website_navbar_templates.xml
@@ -103,85 +103,87 @@
                         <div id="o_new_content_menu_choices" class="o_hidden">
                             <div class="container pt32 pb32">
                                 <div class="row">
-                                    <div groups="website.group_website_designer" class="col-md-4 mb8 o_new_content_element">
+                                    <t t-set="is_system" t-value="env.user.has_group('base.group_system')"/>
+                                    <t t-set="is_designer" t-value="env.user.has_group('website.group_website_designer')"/>
+
+                                    <div t-if='is_designer' class="col-md-4 mb8 o_new_content_element">
                                         <a href="#" data-action="new_page" aria-label="New page" title="New page">
                                             <i class="fa fa-file-o"/>
                                             <p>Page</p>
                                         </a>
                                     </div>
-                                    <t>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_blog')"/>
-                                        <div name="module_website_blog" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element">
-                                            <a href="#" data-action="new_blog_post">
-                                                <i class="fa fa-rss"/>
-                                                <p>Blog Post</p>
-                                            </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_event')"/>
-                                        <div name="module_website_event" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element">
-                                            <a href="#" data-action="new_event">
-                                                <i class="fa fa-ticket"/>
-                                                <p>Event</p>
-                                            </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_forum')"/>
-                                        <div name="module_website_forum" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element o_new_content_element_once">
-                                            <a href="#" data-url="/forum" data-action="new_forum">
-                                                <i class="fa fa-comment"/>
-                                                <p>Forum</p>
-                                            </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_hr_recruitment')"/>
-                                        <div name="module_website_hr_recruitment" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element">
+
+                                    <t t-set="mod" t-value="env.ref('base.module_website_blog')"/>
+                                    <div name="module_website_blog" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element">
+                                        <a href="#" data-action="new_blog_post">
+                                            <i class="fa fa-rss"/>
+                                            <p>Blog Post</p>
+                                        </a>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_event')"/>
+                                    <div name="module_website_event" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element">
+                                        <a href="#" data-action="new_event">
+                                            <i class="fa fa-ticket"/>
+                                            <p>Event</p>
+                                        </a>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_forum')"/>
+                                    <div name="module_website_forum" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element o_new_content_element_once">
+                                        <a href="#" data-url="/forum" data-action="new_forum">
+                                            <i class="fa fa-comment"/>
+                                            <p>Forum</p>
+                                        </a>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_hr_recruitment')"/>
+                                    <div name="module_website_hr_recruitment" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element">
                                             <a href="#">
                                                 <i class="fa fa-briefcase"/>
                                                 <p>Job Offer</p>
                                             </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_sale')"/>
-                                        <div name="module_website_sale" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element">
-                                            <a href="#" data-action="new_product">
-                                                <i class="fa fa-shopping-cart"/>
-                                                <p>Product</p>
-                                            </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_slides')"/>
-                                        <div name="module_website_slides" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element">
-                                            <a href="#" data-action="new_slide_channel">
-                                                <i class="fa module_icon" style="background-image: url('/website/static/src/img/apps_thumbs/website_slide.svg');
-                                                    background-repeat: no-repeat; background-position: center;"/>
-                                                <p>Course</p>
-                                            </a>
-                                        </div>
-                                        <t t-set="mod" t-value="env.ref('base.module_website_livechat')"/>
-                                        <div name="module_website_livechat" groups="base.group_system"
-                                             t-att-data-module-id="mod.id"
-                                             t-att-data-module-shortdesc="mod.shortdesc"
-                                             class="col-md-4 mb8 o_new_content_element o_new_content_element_once">
-                                            <a href="#" data-url="/livechat" data-action="new_channel">
-                                                <i class="fa fa-comments"/>
-                                                <p>Livechat Widget</p>
-                                            </a>
-                                        </div>
-                                    </t>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_sale')"/>
+                                    <div name="module_website_sale" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element">
+                                        <a href="#" data-action="new_product">
+                                            <i class="fa fa-shopping-cart"/>
+                                            <p>Product</p>
+                                        </a>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_slides')"/>
+                                    <div name="module_website_slides" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element">
+                                        <a href="#" data-action="new_slide_channel">
+                                            <i class="fa module_icon" style="background-image: url('/website/static/src/img/apps_thumbs/website_slide.svg');
+                                                background-repeat: no-repeat; background-position: center;"/>
+                                            <p>Course</p>
+                                        </a>
+                                    </div>
+                                    <t t-set="mod" t-value="env.ref('base.module_website_livechat')"/>
+                                    <div name="module_website_livechat" t-if='is_system'
+                                         t-att-data-module-id="mod.id"
+                                         t-att-data-module-shortdesc="mod.shortdesc"
+                                         class="col-md-4 mb8 o_new_content_element o_new_content_element_once">
+                                        <a href="#" data-url="/livechat" data-action="new_channel">
+                                            <i class="fa fa-comments"/>
+                                            <p>Livechat Widget</p>
+                                        </a>
+                                    </div>
                                 </div>
                             </div>
                         </div>
diff --git a/addons/website_blog/views/website_blog_templates.xml b/addons/website_blog/views/website_blog_templates.xml
index d6743324417..48e959ec0d5 100644
--- a/addons/website_blog/views/website_blog_templates.xml
+++ b/addons/website_blog/views/website_blog_templates.xml
@@ -494,7 +494,7 @@ list of filtered posts (by date or tag).
         <attribute name="name"/>
         <attribute name="t-att-data-module-id"/>
         <attribute name="t-att-data-module-shortdesc"/>
-        <attribute name="groups">website.group_website_designer</attribute>
+        <attribute name="t-if">is_designer</attribute>
     </xpath>
 </template>
 
diff --git a/addons/website_event/views/website_templates.xml b/addons/website_event/views/website_templates.xml
index 28d4593c57c..aaebd083f5b 100644
--- a/addons/website_event/views/website_templates.xml
+++ b/addons/website_event/views/website_templates.xml
@@ -7,7 +7,7 @@
         <attribute name="name"/>
         <attribute name="t-att-data-module-id"/>
         <attribute name="t-att-data-module-shortdesc"/>
-        <attribute name="groups">event.group_event_manager</attribute>
+        <attribute name="t-if">is_designer</attribute>
     </xpath>
 </template>
 
diff --git a/addons/website_forum/views/website_forum.xml b/addons/website_forum/views/website_forum.xml
index 4ccab765ed5..fcdf65d4231 100644
--- a/addons/website_forum/views/website_forum.xml
+++ b/addons/website_forum/views/website_forum.xml
@@ -1703,7 +1703,7 @@
         <attribute name="name"/>
         <attribute name="t-att-data-module-id"/>
         <attribute name="t-att-data-module-shortdesc"/>
-        <attribute name="groups">website.group_website_designer</attribute>
+        <attribute name="t-if">is_designer</attribute>
     </xpath>
 </template>
 
diff --git a/addons/website_hr_recruitment/views/website_hr_recruitment_templates.xml b/addons/website_hr_recruitment/views/website_hr_recruitment_templates.xml
index d095fdc932c..04f601d06ea 100644
--- a/addons/website_hr_recruitment/views/website_hr_recruitment_templates.xml
+++ b/addons/website_hr_recruitment/views/website_hr_recruitment_templates.xml
@@ -608,7 +608,7 @@
         <attribute name="name"/>
         <attribute name="t-att-data-module-id"/>
         <attribute name="t-att-data-module-shortdesc"/>
-        <attribute name="groups">hr_recruitment.group_hr_recruitment_manager</attribute>
+        <attribute name="t-if">is_designer</attribute>
     </xpath>
 </template>
 
diff --git a/addons/website_sale/views/templates.xml b/addons/website_sale/views/templates.xml
index ae3f2c49996..ce8a8633c36 100644
--- a/addons/website_sale/views/templates.xml
+++ b/addons/website_sale/views/templates.xml
@@ -1806,7 +1806,7 @@
             <attribute name="name"/>
             <attribute name="t-att-data-module-id"/>
             <attribute name="t-att-data-module-shortdesc"/>
-            <attribute name="groups">sales_team.group_sale_manager</attribute>
+            <attribute name="t-if">env.user.has_group('sales_team.group_sale_manager')</attribute>
         </xpath>
     </template>
 
diff --git a/addons/website_slides/views/website_slides_templates_utils.xml b/addons/website_slides/views/website_slides_templates_utils.xml
index 90591c6eb94..7f217dbbe3f 100644
--- a/addons/website_slides/views/website_slides_templates_utils.xml
+++ b/addons/website_slides/views/website_slides_templates_utils.xml
@@ -70,7 +70,7 @@
         <attribute name="name"/>
         <attribute name="t-att-data-module-id"/>
         <attribute name="t-att-data-module-shortdesc"/>
-        <attribute name="groups">website_slides.group_website_slides_officer</attribute>
+        <attribute name="t-if">env.user.has_group('website_slides.group_website_slides_officer')</attribute>
     </xpath>
 </template>