From 0c8a244e68b14f71b348886047b487b67fed454d Mon Sep 17 00:00:00 2001 From: Toufik Benjaa Date: Thu, 13 Sep 2018 15:48:09 +0200 Subject: [PATCH] [FIX] mass_mailing: check duplicate recipients on mass mailing - When checking if a recipient has already received a mass mailing, the record model for the recipient was not checked. Which leads to false positives. --- addons/mass_mailing/models/mass_mailing.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/mass_mailing/models/mass_mailing.py b/addons/mass_mailing/models/mass_mailing.py index 83a4cb2278a..00dfa06838b 100644 --- a/addons/mass_mailing/models/mass_mailing.py +++ b/addons/mass_mailing/models/mass_mailing.py @@ -610,10 +610,11 @@ class MassMailing(models.Model): """ else: query +=""" - AND s.mass_mailing_id = %%(mailing_id)s; + AND s.mass_mailing_id = %%(mailing_id)s + AND s.model = %%(target_model)s; """ query = query % {'target': target._table, 'mail_field': mail_field} - params = {'mailing_id': self.id, 'mailing_campaign_id': self.mass_mailing_campaign_id.id} + params = {'mailing_id': self.id, 'mailing_campaign_id': self.mass_mailing_campaign_id.id, 'target_model': self.mailing_model_real} self._cr.execute(query, params) seen_list = set(m[0] for m in self._cr.fetchall()) _logger.info(