From 0aa4906843ff0565e4d9f9c212c4ff03bdfb7ff5 Mon Sep 17 00:00:00 2001
From: Martin Geubelle <mge@odoo.com>
Date: Tue, 23 Apr 2019 10:41:54 +0000
Subject: [PATCH] [REF] web, *: remove `one2many_list` widget

This widget was exactly the same as a `one2many` and was kept for backward
compatibility reasons. It can be safely removed in master.

Related to task 1918327
---
 addons/account/views/account_move_views.xml                 | 2 +-
 addons/account/views/partner_view.xml                       | 4 ++--
 addons/analytic/views/analytic_account_views.xml            | 2 +-
 addons/mrp/views/mrp_bom_views.xml                          | 2 +-
 addons/product/views/product_attribute_views.xml            | 6 +++---
 addons/product/views/product_template_views.xml             | 2 +-
 addons/web/static/src/js/fields/field_registry.js           | 3 +--
 .../tests/fields/relational_fields/field_many2one_tests.js  | 2 +-
 addons/web/static/tests/views/view_dialogs_tests.js         | 4 ++--
 doc/reference/javascript_reference.rst                      | 4 ----
 odoo/addons/test_testing_utilities/menu.xml                 | 2 +-
 11 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 03fba65b684..98c4af96b58 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -342,7 +342,7 @@
                     </group>
                     <notebook>
                         <page string="Journal Items">
-                            <field name="line_ids" widget="one2many_list"
+                            <field name="line_ids" widget="one2many"
                               context="{'line_ids': line_ids, 'journal_id': journal_id }">
                                 <tree editable="bottom" string="Journal Items">
                                     <field name="tax_line_id" invisible="1"/>
diff --git a/addons/account/views/partner_view.xml b/addons/account/views/partner_view.xml
index 23ba9220ac8..e696e1b0d96 100644
--- a/addons/account/views/partner_view.xml
+++ b/addons/account/views/partner_view.xml
@@ -40,7 +40,7 @@
                     <notebook>
                         <page name="tax_mapping" string="Tax Mapping">
                         <group>
-                            <field name="tax_ids" widget="one2many_list" nolabel="1">
+                            <field name="tax_ids" widget="one2many" nolabel="1">
                                 <tree name="tax_map_tree" string="Tax Mapping" editable="bottom">
                                     <field name="tax_src_id" domain="[('type_tax_use', '!=', None)]"/>
                                     <field name="tax_dest_id" domain="[('type_tax_use', '!=', None)]"/>
@@ -56,7 +56,7 @@
                         </page>
                         <page name="account_mapping" string="Account Mapping" groups="account.group_account_user">
                         <group>
-                            <field name="account_ids" widget="one2many_list" nolabel="1">
+                            <field name="account_ids" widget="one2many" nolabel="1">
                                 <tree string="Account Mapping" editable="bottom">
                                     <field name="account_src_id"/>
                                     <field name="account_dest_id"/>
diff --git a/addons/analytic/views/analytic_account_views.xml b/addons/analytic/views/analytic_account_views.xml
index 16f271b694a..3c134043ef7 100644
--- a/addons/analytic/views/analytic_account_views.xml
+++ b/addons/analytic/views/analytic_account_views.xml
@@ -26,7 +26,7 @@
                             <field name="active_analytic_distribution" groups="analytic.group_analytic_accounting"/>
                             <field name="company_id" groups="base.group_multi_company"/>
                         </group>
-                        <field name="analytic_distribution_ids" nolabel="1" widget="one2many_list"
+                        <field name="analytic_distribution_ids" nolabel="1" widget="one2many"
                             attrs="{'invisible': [('active_analytic_distribution', '=', False)]}" groups="analytic.group_analytic_accounting">
                             <tree string="Analytic Distribution" editable="bottom">
                                 <field name="account_id"/>
diff --git a/addons/mrp/views/mrp_bom_views.xml b/addons/mrp/views/mrp_bom_views.xml
index dcc222c49b5..4533786ddcb 100644
--- a/addons/mrp/views/mrp_bom_views.xml
+++ b/addons/mrp/views/mrp_bom_views.xml
@@ -53,7 +53,7 @@
                     </group>
                     <notebook>
                         <page string="Components">
-                            <field name="bom_line_ids" widget="one2many_list" context="{'default_parent_product_tmpl_id': product_tmpl_id}">
+                            <field name="bom_line_ids" widget="one2many" context="{'default_parent_product_tmpl_id': product_tmpl_id}">
                                 <tree string="Components" editable="bottom">
                                     <field name="sequence" widget="handle"/>
                                     <field name="product_id" context="{'default_type': 'product'}"/>
diff --git a/addons/product/views/product_attribute_views.xml b/addons/product/views/product_attribute_views.xml
index 1be0135e03c..8e6a551967a 100644
--- a/addons/product/views/product_attribute_views.xml
+++ b/addons/product/views/product_attribute_views.xml
@@ -26,7 +26,7 @@
                 </group>
                 <group name="values_ids">
                     <label for="value_ids" string="Attribute Values"/>
-                    <field name="value_ids" widget="one2many_list" nolabel="1">
+                    <field name="value_ids" widget="one2many" nolabel="1">
                         <tree string="Values" editable="bottom">
                             <field name="sequence" widget="handle"/>
                             <field name="name"/>
@@ -75,7 +75,7 @@
                 <group name="main_field">
                     <label for="attribute_id" string="Attribute Name"/>
                     <field name="attribute_id" nolabel="1"/>
-                    <field name="value_ids" widget="one2many_list">
+                    <field name="value_ids" widget="one2many">
                         <tree string="Values">
                             <field name="name"/>
                         </tree>
@@ -110,7 +110,7 @@
                 <group>
                     <field name="name" />
                     <field name="price_extra" />
-                    <field name="exclude_for" widget="one2many_list" mode="tree">
+                    <field name="exclude_for" widget="one2many" mode="tree">
                         <tree editable="top">
                             <field name="product_tmpl_id" />
                             <field name="value_ids" widget="many2many_tags" options="{'no_create': true}" />
diff --git a/addons/product/views/product_template_views.xml b/addons/product/views/product_template_views.xml
index 9c800274522..e052ca2ae4e 100644
--- a/addons/product/views/product_template_views.xml
+++ b/addons/product/views/product_template_views.xml
@@ -44,7 +44,7 @@
 
             <xpath expr="//page[@name='general_information']" position="after">
                 <page name="variants" string="Variants" groups="product.group_product_variant">
-                    <field name="attribute_line_ids" widget="one2many_list" context="{'show_attribute': False}">
+                    <field name="attribute_line_ids" widget="one2many" context="{'show_attribute': False}">
                         <tree string="Variants" editable="bottom">
                             <field name="attribute_id"/>
                             <field name="value_ids" widget="many2many_tags" options="{'no_create_edit': True}" domain="[('attribute_id', '=', attribute_id)]" context="{'default_attribute_id': attribute_id}"/>
diff --git a/addons/web/static/src/js/fields/field_registry.js b/addons/web/static/src/js/fields/field_registry.js
index ccd5dabdff1..9bf2e65f858 100644
--- a/addons/web/static/src/js/fields/field_registry.js
+++ b/addons/web/static/src/js/fields/field_registry.js
@@ -78,8 +78,7 @@ registry
     .add('many2many_checkboxes', relational_fields.FieldMany2ManyCheckBoxes)
     .add('one2many', relational_fields.FieldOne2Many)
     .add('statusbar', relational_fields.FieldStatus)
-    .add('reference', relational_fields.FieldReference)
-    .add('one2many_list', relational_fields.FieldOne2Many);
+    .add('reference', relational_fields.FieldReference);
 
 // Special fields
 registry
diff --git a/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js b/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
index 419d7c5a4c7..4dedf7e4af2 100644
--- a/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
+++ b/addons/web/static/tests/fields/relational_fields/field_many2one_tests.js
@@ -1805,7 +1805,7 @@ QUnit.module('fields', {}, function () {
                 data: this.data,
                 arch: '<form>' +
                     '<field name="name"/>' +
-                    '<field name="turtle_ids" widget="one2many_list">' +
+                    '<field name="turtle_ids" widget="one2many">' +
                     '<tree string="Turtles" editable="bottom">' +
                     '<field name="type_id"/>' +
                     '</tree>' +
diff --git a/addons/web/static/tests/views/view_dialogs_tests.js b/addons/web/static/tests/views/view_dialogs_tests.js
index 9dd78f3b724..82d77d76674 100644
--- a/addons/web/static/tests/views/view_dialogs_tests.js
+++ b/addons/web/static/tests/views/view_dialogs_tests.js
@@ -284,7 +284,7 @@ QUnit.module('Views', {
             data: this.data,
             arch: '<form>' +
                      '<field name="name"/>' +
-                     '<field name="partner" widget="one2many_list" >' +
+                     '<field name="partner" widget="one2many" >' +
                         '<tree editable="top">' +
                             '<field name="display_name"/>' +
                             '<field name="instrument"/>' +
@@ -295,7 +295,7 @@ QUnit.module('Views', {
             archs: {
                 'partner,false,form': '<form>' +
                                            '<field name="name"/>' +
-                                           '<field name="instrument" widget="one2many_list" mode="tree"/>' +
+                                           '<field name="instrument" widget="one2many" mode="tree"/>' +
                                         '</form>',
 
                 'instrument,false,form': '<form>'+
diff --git a/doc/reference/javascript_reference.rst b/doc/reference/javascript_reference.rst
index 0e6d2578bad..6cf2eb9430c 100644
--- a/doc/reference/javascript_reference.rst
+++ b/doc/reference/javascript_reference.rst
@@ -2144,10 +2144,6 @@ Relational fields
 
     - Supported field types: *char, reference*
 
-- one2many_list (FieldOne2Many)
-    This widget is exactly the same as a FieldOne2Many.  It is registered at this
-    key only for backward compatibility reasons.  Please avoid using this.
-
 
 Client actions
 ==============
diff --git a/odoo/addons/test_testing_utilities/menu.xml b/odoo/addons/test_testing_utilities/menu.xml
index 491a74dda46..60789cb490c 100644
--- a/odoo/addons/test_testing_utilities/menu.xml
+++ b/odoo/addons/test_testing_utilities/menu.xml
@@ -139,7 +139,7 @@
                 <sheet>
                     <notebook>
                         <page>
-                            <field name="line_ids" widget="one2many_list" context="{'line_ids': line_ids}">
+                            <field name="line_ids" widget="one2many" context="{'line_ids': line_ids}">
                                 <tree editable="bottom">
                                     <field name="dummy"/>
                                     <field name="flag" invisible="1" readonly="1"/>