From 0a88ae45d6d7b443d84f659c6a3e2cf0f71c2c48 Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Tue, 29 Aug 2023 16:37:05 +0200
Subject: [PATCH] [IMP] l10n_be_hr_payroll: Move departure reason to hr

Part-of: odoo/odoo#134836
---
 addons/hr/data/hr_data.xml              | 3 +++
 addons/hr/models/hr_departure_reason.py | 7 +++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addons/hr/data/hr_data.xml b/addons/hr/data/hr_data.xml
index a6487ffe2b7..e05352d383e 100644
--- a/addons/hr/data/hr_data.xml
+++ b/addons/hr/data/hr_data.xml
@@ -62,16 +62,19 @@
         <record id="departure_fired" model="hr.departure.reason">
             <field name="sequence">0</field>
             <field name="name">Fired</field>
+            <field name="reason_code">342</field>
         </record>
 
         <record id="departure_resigned" model="hr.departure.reason">
             <field name="sequence">1</field>
             <field name="name">Resigned</field>
+            <field name="reason_code">343</field>
         </record>
 
         <record id="departure_retired" model="hr.departure.reason">
             <field name="sequence">2</field>
             <field name="name">Retired</field>
+            <field name="reason_code">340</field>
         </record>
 
         <record id="contract_type_permanent" model="hr.contract.type">
diff --git a/addons/hr/models/hr_departure_reason.py b/addons/hr/models/hr_departure_reason.py
index f30f792266c..cfb88cbf2d4 100644
--- a/addons/hr/models/hr_departure_reason.py
+++ b/addons/hr/models/hr_departure_reason.py
@@ -12,8 +12,7 @@ class DepartureReason(models.Model):
 
     sequence = fields.Integer("Sequence", default=10)
     name = fields.Char(string="Reason", required=True, translate=True)
-    # YTI TODO: Move reason_code to hr + adapt _unlink_except_default_departure_reasons
-    # to use the codes instead of refs
+    reason_code = fields.Integer()
 
     def _get_default_departure_reasons(self):
         return {
@@ -24,6 +23,6 @@ class DepartureReason(models.Model):
 
     @api.ondelete(at_uninstall=False)
     def _unlink_except_default_departure_reasons(self):
-        master_reasons = [self.env.ref('hr.departure_fired', False), self.env.ref('hr.departure_resigned', False), self.env.ref('hr.departure_retired', False)]
-        if any(reason in master_reasons for reason in self):
+        master_departure_codes = self._get_default_departure_reasons().values()
+        if any(reason.reason_code in master_departure_codes for reason in self):
             raise UserError(_('Default departure reasons cannot be deleted.'))