From 09fbdc9abd83a024eb559657de0be98d1b5df20c Mon Sep 17 00:00:00 2001 From: luvi Date: Mon, 19 Sep 2022 11:57:16 +0000 Subject: [PATCH] [FIX] web: remove unnecessary classes from Notebook This commit removes the 'bg-white' and 'pt-3' classes used in the Notebook template since commit https://github.com/odoo/odoo/commit/68f1c90a031a7c2f751d9c8eca7ff525e9f7e206. Now that the component is used by other components, such as the media dialog from web_editor, it is not appropriate to add such style in the core component. Also, removing the bg-white class has no concrete effect in form views, so it can be removed safely. closes odoo/odoo#100253 Signed-off-by: Quentin Smetz (qsm) --- addons/web/static/src/core/notebook/notebook.scss | 8 ++++---- addons/web/static/src/core/notebook/notebook.xml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/addons/web/static/src/core/notebook/notebook.scss b/addons/web/static/src/core/notebook/notebook.scss index ad31f4fa375..d9d783f0ba6 100644 --- a/addons/web/static/src/core/notebook/notebook.scss +++ b/addons/web/static/src/core/notebook/notebook.scss @@ -1,7 +1,7 @@ .o_notebook { --notebook-margin-x: 0; --notebook-padding-x: 0; - --notebook-link-border-color: transparent; + --notebook-link-border-color: transparent; --notebook-link-border-color-active: #{$border-color}; --notebook-link-border-color-hover: #{$gray-200}; --notebook-link-border-color-active-accent: #{$border-color}; @@ -18,7 +18,7 @@ .nav-item { white-space: nowrap; } - + .nav-link { border: 1px solid var(--notebook-link-border-color, transparent); @@ -47,7 +47,7 @@ width: max-content; border-bottom: 1px solid var(--notebook-link-border-color); } - + .nav-item { margin: 0 -1px -1px 0; @@ -55,7 +55,7 @@ border-top-width: 0; } } - + .nav-link { border: 1px solid var(--notebook-link-border-color, transparent); diff --git a/addons/web/static/src/core/notebook/notebook.xml b/addons/web/static/src/core/notebook/notebook.xml index d819b3818df..55fd1da773d 100644 --- a/addons/web/static/src/core/notebook/notebook.xml +++ b/addons/web/static/src/core/notebook/notebook.xml @@ -10,7 +10,7 @@ -
+