From 09d9911d3035a09d5f3a430bdb629801f7381b81 Mon Sep 17 00:00:00 2001
From: "Andrea Grazioso (agr-odoo)" <agr@odoo.com>
Date: Mon, 27 Apr 2020 07:34:38 +0000
Subject: [PATCH] [FW][FIX] account,pos_cash_rounding: cash rounding account
 choice fix

The cash rounding profit_account_id directly impact the account on the
rounding invoice line. If this is configured with a 'payable' or
'receivable' account such line will be read as term and condition line
in '_recompute_payment_terms_lines', messing up the line amounts

Adding a domain to avoid the wrong choice

opw-2214059

closes odoo/odoo#50205

X-original-commit: 303afca8e86a36ff748050cf60ef779663ac1868
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
---
 addons/account/views/account_cash_rounding_view.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/account_cash_rounding_view.xml b/addons/account/views/account_cash_rounding_view.xml
index de794b64b5d..273246d90b7 100644
--- a/addons/account/views/account_cash_rounding_view.xml
+++ b/addons/account/views/account_cash_rounding_view.xml
@@ -26,9 +26,9 @@
                             <field name="rounding"/>
                             <field name="strategy"/>
                             <field name="profit_account_id" options="{'no_create': True}" attrs="{'invisible': [('strategy', '!=', 'add_invoice_line')], 'required': [('strategy', '=', 'add_invoice_line')]}"
-                                groups="account.group_account_invoice,account.group_account_readonly"/>
+                                groups="account.group_account_invoice,account.group_account_readonly" domain="[('user_type_id.type', 'not in', ('receivable', 'payable'))]"/>
                             <field name="loss_account_id" options="{'no_create': True}" attrs="{'invisible': [('strategy', '!=', 'add_invoice_line')], 'required': [('strategy', '=', 'add_invoice_line')]}"
-                                groups="account.group_account_invoice,account.group_account_readonly"/>
+                                groups="account.group_account_invoice,account.group_account_readonly" domain="[('user_type_id.type', 'not in', ('receivable', 'payable'))]"/>
                             <field name="rounding_method"/>
                         </group>
                     </sheet>