From 087ff42e3a2ae8862d66ab52882354219c8b9d92 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Tue, 19 Sep 2023 15:44:57 +0200
Subject: [PATCH] [IMP] product: stricter documents creation

Do not allow modifying documents types, correctly mark necessary fields
as required, ...

Part-of: odoo/odoo#135894
---
 addons/product/views/product_document_views.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/product/views/product_document_views.xml b/addons/product/views/product_document_views.xml
index 8ffc8f6b39f..16fa9beb2fb 100644
--- a/addons/product/views/product_document_views.xml
+++ b/addons/product/views/product_document_views.xml
@@ -12,9 +12,9 @@
                         <field name="name" readonly="not datas and type != 'url'"/>
                     </h1>
                     <group>
-                        <field name="type"/>
-                        <field name="datas" filename="name" invisible="type == 'url'"/>
-                        <field name="url" widget="url" invisible="type == 'binary'"/>
+                        <field name="type" readonly="datas or id"/>
+                        <field name="datas" filename="name" invisible="type == 'url'" required="type == 'binary'"/>
+                        <field name="url" widget="url" invisible="type == 'binary'" required="type == 'url'"/>
                     </group>
                     <group string="Attached To" groups="base.group_no_one">
                         <field name="res_name"/>