From 074873f8be54927bb969a7275fea8d544e4b8723 Mon Sep 17 00:00:00 2001
From: Vishnu Thuletiya <vtu@odoo.com>
Date: Fri, 15 May 2020 05:34:57 +0000
Subject: [PATCH] [IMP] various: Remove the message_needaction_counter from
 kanban views

Purpose of the task is to remove the needaction message counter from
kanban view due to below reason:
 - The user has access to unread messages on records from the discuss
item in the systray.
 - It is irrelevant for user handling notifications through their mail
client
 - It is only less UI item to worry about on the kanban views (as
features increase, we need to be careful not to clutter the views)
 - The user can still use the message_needaction filter to get records
with unread messages

So in this commit we removed the need action counter from all the
kanban view.

closes odoo/odoo#51299

Taskid: 2257624
Closes: #51299
Related: odoo/enterprise#10613
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/crm/views/crm_lead_views.xml                  | 8 --------
 addons/hr_recruitment/views/hr_recruitment_views.xml | 4 ----
 addons/maintenance/views/maintenance_views.xml       | 4 ----
 addons/project/views/project_views.xml               | 4 ----
 4 files changed, 20 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index bb85db603c4..9e5d4ae732c 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -358,7 +358,6 @@
                     <field name="priority"/>
                     <field name="tag_ids"/>
                     <field name="user_id"/>
-                    <field name="message_needaction_counter"/>
                     <field name="activity_ids"/>
                     <field name="activity_state"/>
                     <progressbar field="activity_state" colors='{"planned": "success", "today": "warning", "overdue": "danger"}'/>
@@ -377,9 +376,6 @@
                                 <div class="o_kanban_record_bottom">
                                     <div class="oe_kanban_bottom_left">
                                         <field name="priority" widget="priority"/>
-                                        <t t-if="record.message_needaction_counter.raw_value">
-                                            <span role="alert" class="oe_kanban_mail_new" title="Unread Messages"><i class="fa fa-comments" aria-label="Messages" role="img"/><t t-raw="record.message_needaction_counter.raw_value"/></span>
-                                        </t>
                                         <div class="o_kanban_inline_block">
                                             <field name="activity_ids" widget="kanban_activity"/>
                                         </div>
@@ -475,7 +471,6 @@
                     <field name="user_email"/>
                     <field name="user_id"/>
                     <field name="partner_address_email"/>
-                    <field name="message_needaction_counter"/>
                     <field name="partner_id"/>
                     <field name="activity_summary"/>
                     <field name="active"/>
@@ -514,9 +509,6 @@
                                     <div class="o_kanban_record_bottom">
                                         <div class="oe_kanban_bottom_left">
                                             <field name="priority" widget="priority" groups="base.group_user"/>
-                                            <t t-if="record.message_needaction_counter.raw_value">
-                                                <span role="alert" class='oe_kanban_mail_new' title='Unread Messages'><i class='fa fa-comments' aria-label="Unread messages" role="img"/><t t-raw="record.message_needaction_counter.raw_value"/></span>
-                                            </t>
                                             <field name="activity_ids" widget="kanban_activity"/>
                                         </div>
                                         <div class="oe_kanban_bottom_right">
diff --git a/addons/hr_recruitment/views/hr_recruitment_views.xml b/addons/hr_recruitment/views/hr_recruitment_views.xml
index 7e666d82a64..b4fc4ad76b2 100644
--- a/addons/hr_recruitment/views/hr_recruitment_views.xml
+++ b/addons/hr_recruitment/views/hr_recruitment_views.xml
@@ -272,7 +272,6 @@
                 <field name="partner_id"/>
                 <field name="job_id"/>
                 <field name="department_id"/>
-                <field name="message_needaction_counter"/>
                 <field name="attachment_number"/>
                 <field name="active"/>
                 <field name="activity_ids" />
@@ -315,9 +314,6 @@
                                         <div class="o_kanban_inline_block mr8">
                                             <field name="activity_ids" widget="kanban_activity"/>
                                         </div>
-                                        <t t-if="record.message_needaction_counter.raw_value">
-                                            <span role="alert" class='oe_kanban_mail_new mr4' title='Unread Messages'><i class='fa fa-comments' role="img" aria-label="Unread messages"/><t t-raw="record.message_needaction_counter.raw_value"/></span>
-                                        </t>
                                     </div>
                                     <div class="oe_kanban_bottom_right">
                                         <a name="action_get_attachment_tree_view" type="object">
diff --git a/addons/maintenance/views/maintenance_views.xml b/addons/maintenance/views/maintenance_views.xml
index 58e80c56c6d..60436b80aee 100644
--- a/addons/maintenance/views/maintenance_views.xml
+++ b/addons/maintenance/views/maintenance_views.xml
@@ -119,7 +119,6 @@
                 <field name="owner_user_id"/>
                 <field name="category_id"/>
                 <field name="kanban_state"/>
-                <field name="message_needaction_counter"/>
                 <field name="activity_ids" />
                 <field name="activity_state" />
                 <progressbar field="kanban_state" colors='{"done": "success", "blocked": "danger"}'/>
@@ -155,9 +154,6 @@
                                 <div class="o_kanban_record_bottom">
                                     <div class="oe_kanban_bottom_left">
                                         <field name="priority" widget="priority"/>
-                                        <t t-if="record.message_needaction_counter.raw_value">
-                                            <span role="alert" class='oe_kanban_mail_new' title='Unread Messages'><i class='fa fa-comments' role="img" aria-label="Unread Messages"/><t t-raw="record.message_needaction_counter.raw_value"/></span>
-                                        </t>
                                         <div class="o_kanban_inline_block ml4 mr4">
                                             <field name="activity_ids" widget="kanban_activity" />
                                         </div>
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index fb897e8379e..80f725c5f0f 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -765,7 +765,6 @@
                     <field name="date_deadline_formatted"/>
                     <field name="is_closed"/>
                     <field name="partner_is_company"/>
-                    <field name="message_needaction_counter"/>
                     <field name="displayed_image_id"/>
                     <field name="active"/>
                     <field name="legend_blocked"/>
@@ -819,9 +818,6 @@
                                     <div class="oe_kanban_bottom_left">
                                         <field name="priority" widget="priority"/>
                                         <field name="activity_ids" widget="kanban_activity"/>
-                                        <t t-if="record.message_needaction_counter.raw_value">
-                                            <span role="alert" class='oe_kanban_mail_new' title='Unread Messages'><i class='fa fa-comments' role="img" aria-label="Unread Messages"/><t t-raw="record.message_needaction_counter.raw_value"/></span>
-                                        </t>
                                         <b t-if="record.rating_ids.raw_value.length">
                                             <span style="font-weight:bold;" class="fa fa-fw mt4 fa-smile-o text-success" t-if="record.rating_last_value.value == 5" title="Latest Rating: Satisfied" role="img" aria-label="Happy face"/>
                                             <span style="font-weight:bold;" class="fa fa-fw mt4 fa-meh-o text-warning" t-if="record.rating_last_value.value == 3" title="Latest Rating: Not Satisfied" role="img" aria-label="Neutral face"/>