From 072c8cc6e4b286f2e8794bc8bda54a036f81026a Mon Sep 17 00:00:00 2001
From: "Jacky (trj)" <trj@odoo.com>
Date: Wed, 17 Feb 2021 10:56:59 +0000
Subject: [PATCH] [IMP]: point_of_sale: price control can be enabled without
 installing pos_hr in pos_config

Before: to enable price control, we first have to install the `pos_hr` module by
enabling the "Authorized Employees" option. Only then was the price control option
visible. It was then possible to enable/keep the price control option while having
the "Authorized Employees" disabled. This behavior did not make sense.

After: Price control is now visible and independent from the `pos_hr` module.
The feature was already implemented in the `point_of_sale` module but the option (in the `pos_config` view) was put in the `pos_hr` module.

Task ID: 2419637
---
 addons/point_of_sale/views/pos_config_view.xml | 11 +++++++++++
 addons/pos_hr/views/pos_config.xml             | 13 -------------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/addons/point_of_sale/views/pos_config_view.xml b/addons/point_of_sale/views/pos_config_view.xml
index a5ec4777f89..43f6e5d49e7 100644
--- a/addons/point_of_sale/views/pos_config_view.xml
+++ b/addons/point_of_sale/views/pos_config_view.xml
@@ -373,6 +373,17 @@
                                 </div>
                             </div>
                         </div>
+                        <div class="col-12 col-lg-6 o_setting_box price_control" title="Only users with Manager access rights for PoS app can modify the product prices on orders.">
+                            <div class="o_setting_left_pane">
+                                <field name="restrict_price_control"/>
+                            </div>
+                            <div class="o_setting_right_pane">
+                                <label for="restrict_price_control" string="Price Control"/>
+                                <div class="text-muted">
+                                    Restrict price modification to managers
+                                </div>
+                            </div>
+                        </div>
                     </div>
                     <h2>Payments</h2>
                     <div class="row mt16 o_settings_container">
diff --git a/addons/pos_hr/views/pos_config.xml b/addons/pos_hr/views/pos_config.xml
index d5ca74a7f4c..7804dae6b60 100644
--- a/addons/pos_hr/views/pos_config.xml
+++ b/addons/pos_hr/views/pos_config.xml
@@ -13,19 +13,6 @@
                     />
                 </div>
             </xpath>
-            <xpath expr="//div[@id='pricing']" position='inside'>
-                <div class="col-12 col-lg-6 o_setting_box price_control" title="Only users with Manager access rights for PoS app can modify the product prices on orders.">
-                    <div class="o_setting_left_pane">
-                        <field name="restrict_price_control"/>
-                    </div>
-                    <div class="o_setting_right_pane">
-                        <label for="restrict_price_control" string="Price Control"/>
-                        <div class="text-muted">
-                            Restrict price modification to managers
-                        </div>
-                    </div>
-                </div>
-            </xpath>
         </field>
     </record>
 </odoo>