From 06d305b06e4cad83f636174bc3adffe1179cc7dd Mon Sep 17 00:00:00 2001
From: Olivier Colson <oco@odoo.com>
Date: Mon, 17 Jun 2019 14:05:42 +0000
Subject: [PATCH] [IMP] l10n_ae: add tax templates for consistency with 12.3

Some taxes were declared as groups with some children having 'type_tax_use' different from 'none'. While this is totally correct from a technical point of view, this meant that the group actually had to stay a group in the new model introduced in 12.3. However, functionally speaking, it was not what was intended. We change that here for consistency with 12.3, and to ease the migration. Databases having installed l10n_ae's chart template before this commit will not be affected, and their groups will stay groups in the future (which makes no problem, they simply will be less easy to configure).

closes odoo/odoo#34189

Signed-off-by: Josse Colpaert <jco@openerp.com>
---
 .../data/account_tax_template_data.xml        | 178 ++++++++++++++++--
 1 file changed, 167 insertions(+), 11 deletions(-)

diff --git a/addons/l10n_ae/data/account_tax_template_data.xml b/addons/l10n_ae/data/account_tax_template_data.xml
index b7299572170..da26c9b4515 100644
--- a/addons/l10n_ae/data/account_tax_template_data.xml
+++ b/addons/l10n_ae/data/account_tax_template_data.xml
@@ -187,8 +187,20 @@
         <field name="tag_ids" eval="[(6,0,[ref('tag_ae_08')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
-    <record id="uae_sale_tax_reverse_charge_5" model="account.tax.template">
-        <field name="name">Reverse Charge TVA -5%(Sale)</field>
+    <record id="uae_sale_tax_5_child_dubai" model="account.tax.template">
+        <field name="name">TVA 5% (Dubai)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_dubai')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_dubai" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Dubai)</field>
         <field name="type_tax_use">none</field>
         <field name="amount">-5.0</field>
         <field name="amount_type">percent</field>
@@ -203,16 +215,60 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_dubai')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_dubai'), ref('uae_sale_tax_5_child_dubai')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_abu_dhabi" model="account.tax.template">
+        <field name="name">TVA 5% (Abu Dhabi)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_abu_dhabi')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_abu_dhabi" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Abu Dhabi)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_abu_dhabi" model="account.tax.template">
-        <field name="name">Reverse Charge Provision (Abi Dhabi)</field>
+        <field name="name">Reverse Charge Provision (Abu Dhabi)</field>
         <field name="type_tax_use">sale</field>
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_abu_dhabi')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_abu_dhabi'), ref('uae_sale_tax_5_child_abu_dhabi')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_sharjah" model="account.tax.template">
+        <field name="name">TVA 5% (Sharjah)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_sharjah')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_sharjah" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Sharjah)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_sharjah" model="account.tax.template">
@@ -221,7 +277,29 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_sharjah')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_sharjah'), ref('uae_sale_tax_5_child_sharjah')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_ajman" model="account.tax.template">
+        <field name="name">TVA 5% (Ajman)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_ajman')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_ajman" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Ajman)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_ajman" model="account.tax.template">
@@ -230,7 +308,29 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_ajman')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_ajman'), ref('uae_sale_tax_5_child_ajman')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_umm_al_quwain" model="account.tax.template">
+        <field name="name">TVA 5% (Umm Al Quwain)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_umm_al_quwain')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_umm_al_quwain" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Umm Al Quwain)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_umm_al_quwain" model="account.tax.template">
@@ -239,7 +339,29 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_umm_al_quwain')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_umm_al_quwain'), ref('uae_sale_tax_5_child_umm_al_quwain')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_ras_al_khaima" model="account.tax.template">
+        <field name="name">TVA 5% (Ras Al-Khaima)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_ras_al_khaima')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_ras_al_khaima" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Ras Al-Khaima)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_ras_al_khaima" model="account.tax.template">
@@ -248,7 +370,29 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_ras_al_khaima')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_ras_al_khaima'), ref('uae_sale_tax_5_child_ras_al_khaima')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_5_child_fujairah" model="account.tax.template">
+        <field name="name">TVA 5% (Fujairah)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3785"/>
+        <field name="refund_account_id" ref="uae_account_3785"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_01_fujairah')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
+    <record id="uae_sale_tax_reverse_charge_5_child_fujairah" model="account.tax.template">
+        <field name="name">Reverse Charge TVA -5%(Sale) (Fujairah)</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">-5.0</field>
+        <field name="amount_type">percent</field>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_09')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_reverse_charge_fujairah" model="account.tax.template">
@@ -257,7 +401,7 @@
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5'), ref('uae_sale_tax_5_fujairah')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_sale_tax_reverse_charge_5_child_fujairah'), ref('uae_sale_tax_5_child_fujairah')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
     <record id="uae_sale_tax_tourist_refund" model="account.tax.template">
@@ -327,13 +471,25 @@
         <field name="tag_ids" eval="[(6,0,[ref('tag_ae_10')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
+    <record id="uae_purchase_tax_5_child_global" model="account.tax.template">
+        <field name="name">TVA 5%</field>
+        <field name="type_tax_use">none</field>
+        <field name="amount">5</field>
+        <field name="amount_type">percent</field>
+        <field name="description">TVA 5%</field>
+        <field name="account_id" ref="uae_account_3726"/>
+        <field name="refund_account_id" ref="uae_account_3726"/>
+        <field name="tax_group_id" ref="ae_tax_group_5"/>
+        <field name="tag_ids" eval="[(6,0,[ref('tag_ae_02')])]"/>
+        <field name="chart_template_id" ref="uae_chart_template_standard"/>
+    </record>
     <record id="uae_purchase_tax_reverse_charge" model="account.tax.template">
         <field name="name">Reverse Charge Provision</field>
         <field name="type_tax_use">purchase</field>
         <field name="amount">0.0</field>
         <field name="amount_type">group</field>
         <field name="description">Supplies subject to reverse charge provisions</field>
-        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_purchase_tax_reverse_charge_5'), ref('uae_purchase_tax_5')])]"/>
+        <field name="children_tax_ids" eval="[(6, 0, [ref('uae_purchase_tax_reverse_charge_5'), ref('uae_purchase_tax_5_child_global')])]"/>
         <field name="chart_template_id" ref="uae_chart_template_standard"/>
     </record>
 </odoo>