From 0629e34715fbbe11272cf85db1e435a610371872 Mon Sep 17 00:00:00 2001
From: dhda-odoo <dhda@odoo.com>
Date: Wed, 11 Oct 2023 14:17:30 +0530
Subject: [PATCH] [FIX] sale_timesheet: project task invoice wizard daterange

saas-16.3

Steps To reproduce:
 - install project, sales, and timesheets
 -  open the project module and select any project created from SO
 - click on any task
 - click on the Sales Order smart button
 - to set the end date hover beside the start date

Issue:
 - end date should not be optional to select.

Cause:
 - the unification of datetime, daterange, and date happened in task 3121497
   where daterange widget has the end date by default optional.

Solution:
 - I have added attrs and Timesheets Period label to have the same behavior as it was in saas-16.2.

task-3506482

closes odoo/odoo#145115

X-original-commit: 1525c426b47c01a950da7f5d1e15d2839bdc8c93
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
---
 addons/sale_timesheet/i18n/sale_timesheet.pot                | 5 +++++
 .../wizard/sale_make_invoice_advance_views.xml               | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/addons/sale_timesheet/i18n/sale_timesheet.pot b/addons/sale_timesheet/i18n/sale_timesheet.pot
index 861d084ce18..bcde8bc3cf1 100644
--- a/addons/sale_timesheet/i18n/sale_timesheet.pot
+++ b/addons/sale_timesheet/i18n/sale_timesheet.pot
@@ -1205,6 +1205,11 @@ msgstr ""
 msgid "Timesheet Encoding Unit"
 msgstr ""
 
+#. module: sale_timesheet
+#: model_terms:ir.ui.view,arch_db:sale_timesheet.sale_advance_payment_inv_timesheet_view_form
+msgid "Timesheets Period"
+msgstr ""
+
 #. module: sale_timesheet
 #: model:ir.model.fields,field_description:sale_timesheet.field_project_project__timesheet_product_id
 #: model:ir.model.fields,field_description:sale_timesheet.field_project_task__timesheet_product_id
diff --git a/addons/sale_timesheet/wizard/sale_make_invoice_advance_views.xml b/addons/sale_timesheet/wizard/sale_make_invoice_advance_views.xml
index f1411006ba0..5944845b70b 100644
--- a/addons/sale_timesheet/wizard/sale_make_invoice_advance_views.xml
+++ b/addons/sale_timesheet/wizard/sale_make_invoice_advance_views.xml
@@ -15,8 +15,11 @@
                     name="timesheet_invoice_date_range"
                     invisible="not invoicing_timesheet_enabled or advance_payment_method != 'delivered'">
                     <field
+                        class="w-75 w-md-50 w-lg-25"
                         name="date_start_invoice_timesheet"
+                        string="Timesheets Period"
                         widget="daterange"
+                        required="date_start_invoice_timesheet or date_end_invoice_timesheet"
                         options="{'end_date_field': 'date_end_invoice_timesheet'}"
                         title="Only timesheets not yet invoiced (and validated, if applicable) from this period will be invoiced. If the period is not indicated, all timesheets not yet invoiced (and validated, if applicable) will be invoiced without distinction."
                     />