From 0587f914b8fe22c24f4ae293c3523a2c0e815a0f Mon Sep 17 00:00:00 2001 From: Chenyun Yang Date: Thu, 3 Aug 2023 13:48:14 +0000 Subject: [PATCH] [FIX] spreadsheet: fix global filter display name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit fixes the bug of undefined filter display name. A few weeks ago the property names of record when updating record selector have been modified. Previously it's `name` but now it's `display_name`. This is the root cause of the bug. task 3453374 closes odoo/odoo#130724 Related: odoo/enterprise#45349 Signed-off-by: Rémi Rahir (rar) --- .../components/records_selector/records_selector.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.js b/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.js index d76956edb6e..f7197b28960 100644 --- a/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.js +++ b/addons/spreadsheet/static/src/global_filters/components/records_selector/records_selector.js @@ -48,11 +48,11 @@ export class RecordsSelector extends Component { } /** - * @param {{ id: number; name?: string}[]} records + * @param {{ id: number; display_name?: string}[]} records */ update(records) { - for (const record of records.filter((record) => record.name)) { - this.displayNames[record.id] = record.name; + for (const record of records.filter((record) => record.display_name)) { + this.displayNames[record.id] = record.display_name; } this.notifyChange(this.props.resIds.concat(records.map(({ id }) => id))); }