From 03a072b4b78aa348a92fdfdcfa16350aadff132b Mon Sep 17 00:00:00 2001 From: "GPA(OpenERP)" <> Date: Wed, 16 Sep 2009 20:37:35 +0530 Subject: [PATCH] [FIX] Hr_holidays : Workflow actions validations corrected lp bug: https://launchpad.net/bugs/430098 fixed bzr revid: jvo@tinyerp.com-20090916150735-2d3cb8a1ybqt164r --- addons/hr_holidays/hr.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addons/hr_holidays/hr.py b/addons/hr_holidays/hr.py index 5e4b1ed7a05..dc0f7a82d66 100644 --- a/addons/hr_holidays/hr.py +++ b/addons/hr_holidays/hr.py @@ -187,8 +187,11 @@ class hr_holidays(osv.osv): 'state':'validate', } ids2 = self.pool.get('hr.employee').search(cr, uid, [('user_id','=', uid)]) + if ids2: vals['manager_id'] = ids2[0] + else: + raise osv.except_osv(_('Warning !'),_('Either there is no Employee defined, or no User attached with it.')) self.write(cr, uid, ids, vals) self._create_holiday(cr, uid, ids) return True @@ -207,6 +210,8 @@ class hr_holidays(osv.osv): def holidays_refuse(self, cr, uid, ids, *args): ids2 = self.pool.get('hr.employee').search(cr, uid, [('user_id','=', uid)]) + if not ids2: + raise osv.except_osv(_('Warning !'),_('Either there is no Employee defined, or no User attached with it.')) self.write(cr, uid, ids, { 'state':'refuse', 'manager_id':ids2[0]