From 0340769af229f9db1f233dbbc42f23fd1424a15f Mon Sep 17 00:00:00 2001
From: FrancoisGe <fge@odoo.com>
Date: Mon, 14 Nov 2022 10:45:39 +0000
Subject: [PATCH] [FIX] web : indeterministic crash in Many2ManyTagsField tests

The goal of this commit is to fix indeterministic crashes
in Many2ManyTagsField test suite.

We could see that the wrong helper was used in some tests. We used
selectDropdownItem after an editInput on this same field.

Cause of the error:
editInput => event input debounce which causes the autocomplete to open.
selectDropdownItem => event click which causes the autocomplete to open.
                     After this event, a second click takes place to
                     select the dropdown item (call to clickOpenedDropdownItem).

The setTimeout is not patched, it is possible that the input event takes
place after the click which does not cause any crash. But if the click
event happens after the input then the autocomplete is closed before
the dropdown item is selected.

To solve this, we will patch the setTimeout and we will use only
clickOpenedDropdownItem to select the dropdownItem.

We also patched the setTimout in all tests to avoid indeterminate
behavior related to the debounce in the autocomplete input.

closes odoo/odoo#105693

X-original-commit: 36f6e6801166865e0c8047c1c2be43ef8826581f
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 .../fields/many2many_tags_field_tests.js      | 29 ++++---------------
 1 file changed, 5 insertions(+), 24 deletions(-)

diff --git a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
index bb87239462d..83ec8cdc767 100644
--- a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
+++ b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
@@ -103,6 +103,9 @@ QUnit.module("Fields", (hooks) => {
         };
 
         setupViewRegistries();
+        patchWithCleanup(browser, {
+            setTimeout: (fn) => Promise.resolve().then(fn),
+        });
     });
 
     QUnit.module("Many2ManyTagsField");
@@ -905,12 +908,10 @@ QUnit.module("Fields", (hooks) => {
             null,
             "new"
         );
-        await selectDropdownItem(target, "timmy", `Create "new"`);
-
+        await clickOpenedDropdownItem(target, "timmy", `Create "new"`);
         assert.containsOnce(target, ".o_field_many2many_tags .badge");
 
         await clickSave(target);
-
         assert.strictEqual(
             target.querySelector(".o_field_many2many_tags").textContent.trim(),
             "new"
@@ -1444,7 +1445,7 @@ QUnit.module("Fields", (hooks) => {
         // try to quick create a record
         await triggerEvent(target, ".o_field_many2many_tags input", "focus");
         await editInput(target, ".o_field_many2many_tags input", "new partner");
-        await selectDropdownItem(target, "timmy", `Create "new partner"`);
+        await clickOpenedDropdownItem(target, "timmy", `Create "new partner"`);
 
         // as the quick create failed, a dialog should be open to 'slow create' the record
         assert.containsOnce(target, ".modal .o_form_view");
@@ -1582,9 +1583,6 @@ QUnit.module("Fields", (hooks) => {
     });
 
     QUnit.test("Many2ManyTagsField supports 'create' props to be a Boolean", async (assert) => {
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
         await makeView({
             type: "form",
             resModel: "partner",
@@ -1625,9 +1623,6 @@ QUnit.module("Fields", (hooks) => {
         serverData.views = {
             "partner_type,false,form": `<form><field name="name"/><field name="color"/></form>`,
         };
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
         await makeView({
             type: "form",
             resModel: "partner",
@@ -1657,9 +1652,6 @@ QUnit.module("Fields", (hooks) => {
     });
 
     QUnit.test("Many2ManyTagsField with option 'no_create' set to true", async (assert) => {
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
         await makeView({
             type: "form",
             resModel: "partner",
@@ -1673,9 +1665,6 @@ QUnit.module("Fields", (hooks) => {
     });
 
     QUnit.test("Many2ManyTagsField with attribute 'can_create' set to false", async (assert) => {
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
         await makeView({
             type: "form",
             resModel: "partner",
@@ -1688,10 +1677,6 @@ QUnit.module("Fields", (hooks) => {
     });
 
     QUnit.test("Many2ManyTagsField with arch context in form view", async (assert) => {
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
-
         await makeView({
             type: "form",
             resModel: "partner",
@@ -1724,10 +1709,6 @@ QUnit.module("Fields", (hooks) => {
     });
 
     QUnit.test("Many2ManyTagsField with arch context in list view", async (assert) => {
-        patchWithCleanup(browser, {
-            setTimeout: (fn) => Promise.resolve().then(fn),
-        });
-
         await makeView({
             type: "list",
             resModel: "partner",