From 0332afc3f581a6bea5c4ef2ca8b6dd94ed32d355 Mon Sep 17 00:00:00 2001
From: clesgow <quwo@odoo.com>
Date: Wed, 19 Apr 2023 11:41:22 +0000
Subject: [PATCH] [IMP] stock{,_dropshipping}: use filters instead of domains
 for pickings

Use filters instead of domains for the `stock.picking` lists accessible
from the menu 'Operations', so all pickings can be easily consulted in a
single view when removing said filter.

Part of task-3218314

Part-of: odoo/odoo#119381
---
 addons/stock/views/stock_picking_views.xml       | 16 ++++++++++------
 .../views/stock_picking_views.xml                | 15 +++++++++++++--
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index fa300ae3ff0..30056099ad8 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -386,6 +386,10 @@
                     <filter name="done" string="Done" domain="[('state', '=', 'done')]" help="Pickings already processed"/>
                     <filter name="cancel" string="Cancelled" domain="[('state', '=', 'cancel')]" help="Cancelled Moves"/>
                     <separator/>
+                    <filter name="reception" string="Receipts" domain="[('picking_type_code', '=', 'incoming')]"/>
+                    <filter name="delivery" string="Deliveries" domain="[('picking_type_code', '=', 'outgoing')]"/>
+                    <filter name="internal" string="Internal" domain="[('picking_type_code', '=', 'internal')]"/>
+                    <separator/>
                     <filter name="late" string="Late" help="Deadline exceed or/and by the scheduled"
                         domain="[('state', 'in', ('assigned', 'waiting', 'confirmed')), '|', '|', ('has_deadline_issue', '=', True), ('date_deadline', '&lt;', current_date), ('scheduled_date', '&lt;', current_date)]"/>
                     <filter string="Planning Issues" name="planning_issues" help="Transfers that are late on scheduled time or one of pickings will be late"
@@ -433,8 +437,8 @@
             <field name="name">Receipts</field>
             <field name="res_model">stock.picking</field>
             <field name="view_mode">tree,kanban,form,calendar</field>
-            <field name="domain">[('picking_type_code', '=', 'incoming')]</field>
-            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'incoming'}</field>
+            <field name="domain"></field>
+            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'incoming', 'search_default_reception': 1}</field>
             <field name="search_view_id" ref="view_picking_internal_search"/>
             <field name="help" type="html">
                 <p class="o_view_nocontent_smiling_face">
@@ -449,8 +453,8 @@
             <field name="name">Deliveries</field>
             <field name="res_model">stock.picking</field>
             <field name="view_mode">tree,kanban,form,calendar</field>
-            <field name="domain">[('picking_type_code', '=', 'outgoing')]</field>
-            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'outgoing'}</field>
+            <field name="domain"></field>
+            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'outgoing', 'search_default_delivery': 1}</field>
             <field name="search_view_id" ref="view_picking_internal_search"/>
             <field name="help" type="html">
                 <p class="o_view_nocontent_smiling_face">
@@ -465,8 +469,8 @@
             <field name="name">Internal Transfers</field>
             <field name="res_model">stock.picking</field>
             <field name="view_mode">tree,kanban,form,calendar</field>
-            <field name="domain">[('picking_type_code', '=', 'internal')]</field>
-            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'internal'}</field>
+            <field name="domain"></field>
+            <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'internal', 'search_default_internal': 1}</field>
             <field name="search_view_id" ref="view_picking_internal_search"/>
             <field name="help" type="html">
                 <p class="o_view_nocontent_smiling_face">
diff --git a/addons/stock_dropshipping/views/stock_picking_views.xml b/addons/stock_dropshipping/views/stock_picking_views.xml
index 0331edcc15c..2c2004785c0 100644
--- a/addons/stock_dropshipping/views/stock_picking_views.xml
+++ b/addons/stock_dropshipping/views/stock_picking_views.xml
@@ -1,11 +1,22 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
+    <record id="view_picking_internal_search_inherit_stock_dropshipping" model="ir.ui.view">
+        <field name="name">stock.picking.search</field>
+        <field name="model">stock.picking</field>
+        <field name="inherit_id" ref="stock.view_picking_internal_search"/>
+        <field name="arch" type="xml">
+            <xpath expr="//filter[@name='internal']" position="after">
+                <filter name="dropships" string="Dropships" domain="[('picking_type_code', '=', 'dropship')]"/>
+            </xpath>
+        </field>
+    </record>
+
     <record id="action_picking_tree_dropship" model="ir.actions.act_window">
         <field name="name">Dropships</field>
         <field name="res_model">stock.picking</field>
         <field name="view_mode">tree,kanban,form,calendar</field>
-        <field name="domain">[('picking_type_code', '=', 'dropship')]</field>
-        <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'dropship'}</field>
+        <field name="domain"></field>
+        <field name="context">{'contact_display': 'partner_address', 'default_company_id': allowed_company_ids[0], 'restricted_picking_type_code': 'dropship', 'search_default_dropships': 1}</field>
         <field name="search_view_id" ref="stock.view_picking_internal_search"/>
     </record>