From 013fbb109abbfeddcce2999cb67248e687b887ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Maes?= Date: Wed, 27 Sep 2017 15:07:22 +0200 Subject: [PATCH] [FIX] crm: avoid crash when creating activity When creating an acitivity generating a calendar event, if the model is not crm.lead (ex: sale.order), the default_get will crash since no value for res_model_id is given. --- addons/crm/models/calendar.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addons/crm/models/calendar.py b/addons/crm/models/calendar.py index 136251bce71..8a13f3d3a17 100644 --- a/addons/crm/models/calendar.py +++ b/addons/crm/models/calendar.py @@ -18,8 +18,7 @@ class CalendarEvent(models.Model): # sync res_model / res_id to opportunity id (aka creating meeting from lead chatter) if 'opportunity_id' not in defaults and defaults.get('res_id') and (defaults.get('res_model') or defaults.get('res_model_id')): - if (defaults.get('res_model') and defaults['res_model'] == 'crm.lead') or \ - (defaults.get('res_model_id') and self.env['ir.model'].sudo().browse(defaults['res_model_id']).model == 'crm.lead'): + if (defaults.get('res_model') and defaults['res_model'] == 'crm.lead') or (defaults.get('res_model_id') and self.env['ir.model'].sudo().browse(defaults['res_model_id']).model == 'crm.lead'): defaults['opportunity_id'] = defaults['res_id'] return defaults