From 010bbcd9fefb1899228e32d3987ba92f0c8bfa65 Mon Sep 17 00:00:00 2001 From: "Simon Genin (ges)" Date: Fri, 11 Jun 2021 13:19:41 +0000 Subject: [PATCH] [REF] web: errors remove non-needed event closes odoo-dev/odoo#953 Signed-off-by: Aaron Bohy (aab) --- .../web/static/src/core/errors/error_service.js | 1 - .../tests/core/errors/error_service_tests.js | 15 ++++++--------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/addons/web/static/src/core/errors/error_service.js b/addons/web/static/src/core/errors/error_service.js index be707b9ac6a..c8725927fac 100644 --- a/addons/web/static/src/core/errors/error_service.js +++ b/addons/web/static/src/core/errors/error_service.js @@ -95,7 +95,6 @@ export const errorService = { break; } } - env.bus.trigger("ERROR_DISPATCHED", error); } window.addEventListener("error", async (ev) => { diff --git a/addons/web/static/tests/core/errors/error_service_tests.js b/addons/web/static/tests/core/errors/error_service_tests.js index 078afcd777a..0a5ade8c3d5 100644 --- a/addons/web/static/tests/core/errors/error_service_tests.js +++ b/addons/web/static/tests/core/errors/error_service_tests.js @@ -235,8 +235,11 @@ QUnit.test("handle uncaught CORS errors", async (assert) => { QUnit.test("check retry", async (assert) => { assert.expect(3); - const def = makeDeferred(); + errorHandlerRegistry.add("__test_handler__", () => { + assert.step("dispatched"); + }); + const def = makeDeferred(); patchWithCleanup(browser, { setTimeout(fn) { def.then(fn); @@ -244,11 +247,7 @@ QUnit.test("check retry", async (assert) => { }); serviceRegistry.remove("dialog"); - const env = await makeTestEnv(); - - env.bus.on("ERROR_DISPATCHED", null, () => { - assert.step("ERROR_DISPATCHED"); - }); + await makeTestEnv(); class TestError extends Error {} const error = new TestError(); @@ -264,7 +263,5 @@ QUnit.test("check retry", async (assert) => { await nextTick(); await def.resolve(); - assert.verifySteps(["ERROR_DISPATCHED"]); - - env.bus.off("ERROR_DISPATCHED", null); + assert.verifySteps(["dispatched"]); });