From 00a10fdd001d264a7f5df191b2b9d17c490bfa1c Mon Sep 17 00:00:00 2001 From: Nguyen Tan Phuc Date: Wed, 31 Jan 2018 17:45:31 +0700 Subject: [PATCH] [FIX] point_of_sale : wrong currency decimals To have the same behavior as `_compute_decimal_places` in python When setting rounding of currency > 10, POS will get negative decimals instead value 0 and crash Closes #22199 --- addons/point_of_sale/static/src/js/models.js | 2 +- doc/cla/individual/phucngta.md | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 doc/cla/individual/phucngta.md diff --git a/addons/point_of_sale/static/src/js/models.js b/addons/point_of_sale/static/src/js/models.js index 7b32e286172..2ede35f8e69 100644 --- a/addons/point_of_sale/static/src/js/models.js +++ b/addons/point_of_sale/static/src/js/models.js @@ -330,7 +330,7 @@ exports.PosModel = Backbone.Model.extend({ ids: function(self){ return [self.config.currency_id[0]]; }, loaded: function(self, currencies){ self.currency = currencies[0]; - if (self.currency.rounding > 0) { + if (self.currency.rounding > 0 && self.currency.rounding < 1) { self.currency.decimals = Math.ceil(Math.log(1.0 / self.currency.rounding) / Math.log(10)); } else { self.currency.decimals = 0; diff --git a/doc/cla/individual/phucngta.md b/doc/cla/individual/phucngta.md new file mode 100644 index 00000000000..c53fe2b7136 --- /dev/null +++ b/doc/cla/individual/phucngta.md @@ -0,0 +1,11 @@ +Vietnam, 2018.01.17 + +I hereby agree to the terms of the Odoo Individual Contributor License +Agreement v1.0. + +I declare that I am authorized and able to make this agreement and sign this +declaration. + +Signed, + +Nguyen Phuc https://github.com/phucngta \ No newline at end of file