From 007669feac1fbf46860a22d17ab480c83937d735 Mon Sep 17 00:00:00 2001 From: Toufik Ben Jaa Date: Mon, 10 Dec 2018 10:46:27 +0100 Subject: [PATCH] [FIX] sale: do not schedule activity when no `user_id` - The `_write` override on `sale.order` create a Next Activity for the SO's salesperson when changing the SO `invoice_status` to upselling. If the SO doesn't have a salesperson this code crashes since `user_id` is required on Next Activities. To avoid this crash we create the Next Activity only if a salesperson is set on the SO. OPW-1914087 --- addons/sale/models/sale.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/sale/models/sale.py b/addons/sale/models/sale.py index 188063018d5..b9d063ebf32 100644 --- a/addons/sale/models/sale.py +++ b/addons/sale/models/sale.py @@ -309,7 +309,7 @@ class SaleOrder(models.Model): if 'invoice_status' in values: self.activity_unlink(['sale.mail_act_sale_upsell']) if values['invoice_status'] == 'upselling': - for order in self: + for order in self.filtered('user_id'): order.activity_schedule( 'sale.mail_act_sale_upsell', fields.Date.today(), user_id=order.user_id.id,